Use more of the CLI rather than custom build steps to validate new pr… #4604
Conversation
…ror on run-windows
| let localNuget = execSync('where nuget') | ||
| .toString() | ||
| .trim(); | ||
| // Ensure the local nuget exe is at least version 4.6 |
There was a problem hiding this comment.
what is it about 4.6? maybe clarify in the comment?
There was a problem hiding this comment.
I was duplicating various things we've had with out CI loops requiring newer versions of nuget. But looking through it, that might be specific to azure dev ops, and not apply to consumers.
There is also a requirement to have a new enough version to support variables during publish. But again that might not be needed. I'll remove the version check for now.
| `${path.resolve(__dirname, 'windows').replace(/[/\\]/g, '/')}.*`, | ||
| ), | ||
| // This prevents "react-native run-windows" from hitting: EBUSY: resource busy or locked, open msbuild.ProjectImports.zip | ||
| new RegExp( |
There was a problem hiding this comment.
How hard do you think it would be to generally avoid putting build files in a place where metro will try to read them?
There was a problem hiding this comment.
I have no idea what controls the location of msbuild.ProjectImports.zip. If someone does, then I would agree.
acoates-ms
added
the
AutoMerge
|
Hello @acoates-ms! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
microsoft#4604) * Use more of the CLI rather than custom build steps to validate new projects * Switch master to only publish nightly * syntax * syntax * typo * Test * test * syntax * fix cwd * Add msbuild.ProjectImports.zip to default blacklist to avoid metro error on run-windows * Change files * Use a local version of nuget if available * review feedback * put private nuget package where nuget will find it * Another attempt to get cli to pick up private nuget * syntax * typo
3 participants
…ojects
Also moving publish to be nightly instead of on every push.
Closes #4464
Microsoft Reviewers: Open in CodeFlow