Rename DeveloperSettings.SourceBundlePath -> SourceBundleName #4608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickGerleman
approved these changes
Apr 15, 2020
Contributor
|
You'll need to run "yarn change” to generate a change file for CI to pass. |
Contributor
Author
|
@NickGerleman thanks! |
asklar
reviewed
Apr 15, 2020
| stackFrameUri.append(devSettings.SourceBundleHost.empty() ? "localhost" : devSettings.SourceBundleHost); | ||
| stackFrameUri.append(":"); | ||
| stackFrameUri.append(devSettings.SourceBundlePath.empty() ? "8081" : devSettings.SourceBundlePort); | ||
| stackFrameUri.append(devSettings.SourceBundlePort.empty() ? "8081" : devSettings.SourceBundlePort); |
Member
There was a problem hiding this comment.
SourceBundlePort [](start = 43, length = 16)
good catch
asklar
reviewed
Apr 15, 2020
| std::string SourceBundlePath; // {PATH} | ||
| std::string SourceBundleExtension; // {EXTENSION} | ||
| std::string SourceBundleHost; // Host domain (without port) for the bundler server. Default: "localhost". | ||
| std::string SourceBundlePort; // Host port for the bundler server. Default: "8081". |
Member
There was a problem hiding this comment.
std::string SourceBundlePort [](start = 0, length = 30)
why not just store this as a ushort?
Contributor
Author
There was a problem hiding this comment.
Eventually all these stuff will be assembled to a URL for debug that's then passed to React Native as a std::string. I think storing ushort might not be worth the trouble of itoa?
asklar
approved these changes
Apr 15, 2020
chrisglein
added
the
Breaking Change
statm
added
the
AutoMerge
|
Hello @statm! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
statm
added
Breaking Change
ghost
merged commit
asklar
pushed a commit
to asklar/react-native-windows
that referenced
this pull request
Apr 19, 2020
…oft#4608) * Rename DeveloperSettings.SourceBundlePath -> SourceBundleName * Change files * clang format
Contributor
NickGerleman
removed
the
Breaking Change
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using web debugging and/or live reload, source bundle is obtained from the packager.
The source url for the bundle is
http://{HOST}:{PORT}/{NAME}{EXTENSION}?platform={PLATFORM}where:Currently, the
NAMEfield is namedSourceBundlePath, which incorrectly implies file path. This CR renames it toSourceBundleName.(There seems to be a typo in
RedBox.cpp. Also fixed that.)Microsoft Reviewers: Open in CodeFlow