Remove Clang Format Pre-Commit Hook #4610
Conversation
I don't think this fully works correcty, and unlike lint-staged, `yarn format` has a pretty significant latency. Remove the hook for now.
|
Yeah I think the issue is that just doing yarn format tries to run on all the files in the repo. Really a hook like this should only run on the files you are commiting. -- Then it would be fast enough. It also seems to run async, which means the formatting changes would miss the commit, which kind of defeated the purpose. I'd prefer a fix for the above, but removing for now is fine. |
|
Can we remove husky as a dep if we are not using it? |
|
@acoates-ms IIRC the non CI variant of yarn format does already only scan files that are staged, or at least tries to have some optimization. We've seen some odd behavior with everything happening before though, where I wonder if there is some standard tooling we could utilize instead of our scripts. I can remove Husky. I thought to leave it bc we would add something else, but it seems easy enough to just add it back then. |
* Remove Clang Format Pre-Commit Hook I don't think this fully works correcty, and unlike lint-staged, `yarn format` has a pretty significant latency. Remove the hook for now. * Remove Husky
3 participants
I don't think this fully works correcty, and unlike lint-staged,
yarn formathas a pretty significant latency. Remove the hook for now.Microsoft Reviewers: Open in CodeFlow