Fix PickerWindows (and DatePickerExample Page) #4613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes microsoft#4597 Our implementation of Picker is a bit deformed. In Stock React Native, Picker.js will delegate to PickerAndroid and PickerIOS. In Windows, we the two are copy pasted. In 0.62, invariants are added to prevent duplicate view manager registration. We run into issues with this with Picker, since our copies will both call requireNativeComponent. This change modifies the normal picker to delegate to PickerWindows to work correctly from the stock picker. I.e. The stock picker's child views are meant for data only and will throw if rendered, where the Windows version's are included but used to noop render. Picker is getting lean-cored, so I didn't invest much into fixing PickerWindow's isssues, converting to Flow, NativeComponent strucutre, etc. Validated Picker, PickerWindows, DatePicker RNTester pages work correctly.
NickGerleman
commented
Apr 15, 2020
| class PickerItem extends React.Component<IPickerItemProps> { | ||
| public render(): JSX.Element | null { | ||
| return null; | ||
| throw null; |
Contributor
Author
There was a problem hiding this comment.
throw null is kind of crazy, but matches upstream behavior/behavior in Picker.js
NickGerleman
commented
Apr 15, 2020
| const props = {...this.props}; | ||
| props.onStartShouldSetResponder = () => true; | ||
| props.onResponderTerminationRequest = () => false; | ||
| props.style = this.props.style; |
Contributor
Author
There was a problem hiding this comment.
This line doesn't seem to do anything useful. We already do a shallow clone of props including props.style with const props = {...this.props}; above.
NickGerleman
commented
Apr 15, 2020
| props.onStartShouldSetResponder = () => true; | ||
| props.onResponderTerminationRequest = () => false; | ||
| props.style = this.props.style; | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars |
Contributor
Author
There was a problem hiding this comment.
There's a setting to disable this check when adjacent to the rest parameter that's off by default, but not in stock RN eslint rules that we're using apparently. I'd be fine changing that as well.
vmoroz
reviewed
Apr 15, 2020
| ); | ||
| } else if (Platform.OS === 'windows') { | ||
| return ( | ||
| <PickerWindows {...this.props}>{this.props.children}</PickerWindows> // [Windows] |
Member
There was a problem hiding this comment.
// [Windows] [](start = 77, length = 12)
Could we remove it? It seems to bring no value.
Contributor
Author
There was a problem hiding this comment.
We've been using that to annotate differences in Windows patches. E.g. to ctrl+F for without opening a diff tool.
asklar
pushed a commit
to asklar/react-native-windows
that referenced
this pull request
Apr 19, 2020
* Fix PickerWindows (and DatePickerExample Page) Fixes microsoft#4597 Our implementation of Picker is a bit deformed. In Stock React Native, Picker.js will delegate to PickerAndroid and PickerIOS. In Windows, we the two are copy pasted. In 0.62, invariants are added to prevent duplicate view manager registration. We run into issues with this with Picker, since our copies will both call requireNativeComponent. This change modifies the normal picker to delegate to PickerWindows to work correctly from the stock picker. I.e. The stock picker's child views are meant for data only and will throw if rendered, where the Windows version's are included but used to noop render. Picker is getting lean-cored, so I didn't invest much into fixing PickerWindow's isssues, converting to Flow, NativeComponent strucutre, etc. Validated Picker, PickerWindows, DatePicker RNTester pages work correctly. * Change files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4597
Our implementation of Picker is a bit deformed. In Stock React Native, Picker.js will delegate to PickerAndroid and PickerIOS. In Windows, we the two are copy pasted. In 0.62, invariants are added to prevent duplicate view manager registration. We run into issues with this with Picker, since our copies will both call requireNativeComponent. This change modifies the normal picker to delegate to PickerWindows to work correctly from the stock picker. I.e. The stock picker's child views are meant for data only and will throw if rendered, where the Windows version's are included but used to noop render.
Picker is getting lean-cored, so I didn't invest much into fixing PickerWindow's isssues, converting to Flow, NativeComponent strucutre, etc.
Validated Picker, PickerWindows, DatePicker RNTester pages work correctly.
Microsoft Reviewers: Open in CodeFlow