Skip to content

Added inline to REACT_STRUCT's GetStructInfo to use in header files #4659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Apr 21, 2020
Merged

Added inline to REACT_STRUCT's GetStructInfo to use in header files #4659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
855f780
Added inline to REACT_STRUCT's GetStructInfo to use in header files
vmoroz Apr 21, 2020
b772d85
Change files
vmoroz Apr 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions change/react-native-windows-2020-04-21-09-24-21-Fix_REACT_STRUCT_inline_issue.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "patch",
"comment": "Added inline to REACT_STRUCT's GetStructInfo to use in header files",
"packageName": "react-native-windows",
"email": "vmorozov@microsoft.com",
"dependentChangeType": "patch",
"date": "2020-04-21T16:24:21.711Z"
}
2 changes: 1 addition & 1 deletion vnext/Microsoft.ReactNative.Cxx/StructInfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

#define REACT_STRUCT(type) \
struct type; \
winrt::Microsoft::ReactNative::FieldMap GetStructInfo(type *) noexcept { \
inline winrt::Microsoft::ReactNative::FieldMap GetStructInfo(type *) noexcept { \
winrt::Microsoft::ReactNative::FieldMap fieldMap{}; \
winrt::Microsoft::ReactNative::CollectStructFields<type, __COUNTER__>(fieldMap); \
return fieldMap; \
Expand Down