Skip to content

Opening the devmenu should attempt to connect to dev tools #4660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
3 commits merged into from
Apr 21, 2020
Merged

Opening the devmenu should attempt to connect to dev tools #4660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95f633e
Fix devtools connection to match RN0.62
acoates-ms Apr 21, 2020
a92fd25
Change files
acoates-ms Apr 21, 2020
2444e8f
review feedback
acoates-ms Apr 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions change/react-native-windows-2020-04-21-09-35-21-devtoolsfix.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "prerelease",
"comment": "Fix devtools connection to match RN0.62",
"packageName": "react-native-windows",
"email": "acoates@microsoft.com",
"dependentChangeType": "patch",
"date": "2020-04-21T16:35:21.511Z"
}
6 changes: 6 additions & 0 deletions vnext/Microsoft.ReactNative/Views/ReactRootControl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,6 +564,12 @@ void ReactRootControl::ShowDeveloperMenu() noexcept {
auto xamlRootGrid{xamlRootView.as<winrt::Grid>()};
xamlRootGrid.Children().Append(m_developerMenuRoot);
}

// Notify instance that dev menu is shown -- This is used to trigger a connection to dev tools
if (auto instance = m_weakReactInstance.GetStrongPtr()) {
query_cast<Mso::React::ILegacyReactInstance &>(*instance).CallJsFunction(
"RCTNativeAppEventEmitter", "emit", folly::dynamic::array("RCTDevMenuShown"));
}
}

void ReactRootControl::DismissDeveloperMenu() noexcept {
Expand Down