Hitting 'r' in the packager should reload the instance #4665
Conversation
| auto response = | ||
| std::string(Microsoft::Common::Utilities::CheckedReinterpretCast<char *>(data.data()), data.size()); | ||
| auto json = | ||
| winrt::Windows::Data::Json::JsonObject::Parse(Microsoft::Common::Unicode::Utf8ToUtf16(response)); |
There was a problem hiding this comment.
could use folly::parseJSON here instead but this is fine too
There was a problem hiding this comment.
Trying to avoid adding extra folly usage, since long term once we are off the legacy bridge, we might be able to ditch folly altogether.
acoates-ms
added
the
AutoMerge
|
Hello @acoates-ms! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
| DownloadFromAsync(facebook::react::DevServerHelper::get_LaunchDevToolsCommandUrl(settings.debugHost)).get(); | ||
| } | ||
|
|
||
| std::future<void> DevSupportManager::CreatePackagerConnection(const facebook::react::DevSettings &settings) { |
There was a problem hiding this comment.
std::future [](start = 0, length = 17)
Is it possible to avoid using the std::future? It does not offer a continuation. The only way to observe it is to block a thread which is an anti-pattern.
It is better to use either IAsyncAction or Mso::Future.
| #ifdef DEFAULT_CPPWINRT_EXCEPTIONS | ||
| co_await async; | ||
| #else | ||
| co_await lessthrow_await_adapter<winrt::Windows::Foundation::IAsyncAction>{async}; |
There was a problem hiding this comment.
- What does this do?
- Any reason this is using std::future instead of winrt::fire_and_forget as some other code does?
|
|
||
| try { | ||
| LaunchDevTools(settings); | ||
| CreatePackagerConnection(settings); |
There was a problem hiding this comment.
CreatePackagerConnection [](start = 4, length = 24)
Why do we ignore the result?
Would it be better to have a sequence of async actions uisng .Then or co_await?
4 participants
The packager implements a websocket that allows apps to be recieve commands from the packager. Two obvious commands are 'reload' and 'show devmenu'.
This PR makes the instance connect to this websocket and see the commands. It hooks up reload. The dev menu command is left as a todo for now, as the dev menu is currently tied to the root view, which is probably incorrect and will require some more refactoring.
Microsoft Reviewers: Open in CodeFlow