Microsoft.ReactNative Nuget only contains debug bits #4674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmoroz
reviewed
Apr 22, 2020
| <file src="$nugetroot$\x86\Debug\Microsoft.ReactNative\Microsoft.ReactNative.pdb" target="runtimes\win10-x86\native\debug" /> | ||
| <file src="$nugetroot$\x86\Debug\Microsoft.ReactNative\Microsoft.ReactNative.pri" target="runtimes\win10-x86\native\debug" /> | ||
|
|
||
| <file src="$nugetroot$\x64\Release\Microsoft.ReactNative\Microsoft.ReactNative.dll" target="runtimes\win10-x64\native" /> |
Member
There was a problem hiding this comment.
native [](start = 115, length = 6)
Should we put Release bits under 'release' folder then too?
vmoroz
reviewed
Apr 22, 2020
| <ReferenceCopyLocalPaths Include="$(MSBuildThisFileDirectory)..\..\runtimes\win10-$(Native-Platform)\native\Microsoft.ReactNative.pri" /> | ||
| <ReferenceCopyLocalPaths Condition="${Configuration) == 'Debug'" Include="$(MSBuildThisFileDirectory)..\..\runtimes\win10-$(Native-Platform)\native\debug\Microsoft.ReactNative.dll" /> | ||
| <ReferenceCopyLocalPaths Condition="${Configuration) == 'Debug'" Include="$(MSBuildThisFileDirectory)..\..\runtimes\win10-$(Native-Platform)\native\debug\Microsoft.ReactNative.pri" /> | ||
| <ReferenceCopyLocalPaths Condition="${Configuration) != 'Debug'" Include="$(MSBuildThisFileDirectory)..\..\runtimes\win10-$(Native-Platform)\native\Microsoft.ReactNative.dll" /> |
Member
There was a problem hiding this comment.
!= 'Debug' [](start = 56, length = 11)
It would be better to be explicit about == 'Release' here just in case if someone adds another configuration and they start to conflict here.
Contributor
Author
There was a problem hiding this comment.
Thats why I did != Debug. That way at least they will always get one of the versions. If I did == Release, then it wouldn't build if they made up some other configuration.
acoates-ms
added
the
AutoMerge
|
Hello @acoates-ms! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidently had the release and debug bits overwrite each other in the nuspec. This fixes the nuget to publish both ship and debug, and modifies the default project to use the debug dll when building debug.
Microsoft Reviewers: Open in CodeFlow