Fixed .Net Native crash for custom struct deserialization #4696
Conversation
vmoroz
requested review from
a team,
NickGerleman,
NikoAri,
acoates-ms,
aeulitz and
jonthysell
vmoroz
added
the
AutoMerge
|
Hello @vmoroz! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes, a condition that will be fulfilled in about 44 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
|
||
| public static void ReadClass<TClass>(IJSValueReader reader, out TClass value) where TClass : new() | ||
| { | ||
| // .Net Native seems to have a bug that does not allow to have 'out' or 'ref' parameters. |
There was a problem hiding this comment.
bug [](start = 37, length = 3)
(nit) would be nice to contact .net team with this issue :)
There was a problem hiding this comment.
There was a problem hiding this comment.
@vmoroz could you file a bug in the dotnet runtime project?
https://github.com/dotnet/runtime
| : Default(typeof(void)))))); | ||
| } | ||
| var fields = | ||
| from field in classType.GetFields(BindingFlags.Public | BindingFlags.Instance) |
There was a problem hiding this comment.
nit: seems indention seems to have accidentally changed
| from field in classType.GetFields(BindingFlags.Public | BindingFlags.Instance) | |
| from field in classType.GetFields(BindingFlags.Public | BindingFlags.Instance) |
There was a problem hiding this comment.
vmoroz
removed
the
AutoMerge
vmoroz
added
the
AutoMerge
ghost
merged commit 5 participants
The investigation has shown that the .Net Native does not allow to have a parameter passed as 'ref' in a dynamically generated lambda. It was causing a crash when we generate ReadValue lambda to read custom class or struct where we pass the type by 'ref'.
In this PR we work around this issue by having a different delegate signature used for generating custom class reader. It uses return value instead of 'ref' parameter.
This change only affect the internal implementation of the Microsoft.ReactNative.SharedManaged code. There are no changes in user code required.
Closes #3838
Microsoft Reviewers: Open in CodeFlow