Expose YellowBox functionality to native code #4740
Conversation
asklar
added
the
AutoMerge
|
Hello @asklar! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
| #ifdef DEBUG | ||
| else if (propertyValue.isNull()) { | ||
| // Log error, must have a color | ||
| YellowBox("IconShadowNode - color property must be non-null"); |
There was a problem hiding this comment.
Generally Facebook only does this warning once per instance. You wouldn't want your app spammed with this error.
Unfortunately their warnOnce API isn't exposed to native. But then again, its probably not hard to do something on the native side to only do this once.
There was a problem hiding this comment.
@acoates-ms YellowBox already aggregates/coalesces like warnings into one and you just get one warning per message, with a badge for the # of times it has hit.
There was a problem hiding this comment.
I believe that it only does that if it matches the last error. So once we have multiple of these it would get very spammy.
There was a problem hiding this comment.
@acoates-ms confirmed that when I get the 53 test ones, then go to another page that shows a yellow box, then go to the 53 test yellowbox, the test yellowbox correctly adds those up and brings it to the top:
ghost
merged commit 3 participants
Fixes #1039
Microsoft Reviewers: Open in CodeFlow