Skip to content

Conversation

@asklar
Copy link
Member

@asklar asklar commented Apr 29, 2020

Try uninstalling without elevation in case since it is not needed for layout installs (debug).
Fixes #4744

Microsoft Reviewers: Open in CodeFlow

@asklar asklar requested a review from a team as a code owner April 29, 2020 10:41
@asklar asklar added the AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) label Apr 29, 2020
@ghost
Copy link

ghost commented Apr 29, 2020

Hello @asklar!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@asklar asklar changed the title Remove unnecessary elevation Remove unnecessary CLI elevation Apr 29, 2020
@vmoroz
Copy link
Member

vmoroz commented Apr 29, 2020

The change file is missing.

Copy link
Member

@vmoroz vmoroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ghost ghost merged commit 297e217 into microsoft:master Apr 29, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI doesn't need to elevate to uninstall app for layout install

2 participants