Implement Keyboarding/Gamepad Activation for Pressability #4930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes microsoft#4598 This change reenables touchables to be activated by keyboard/Gamepad. The implementation is mostly stolen from the previous that was used for Touchable. Like before, this doesn't participate in the input state machine, as its coupled to touch input. This means we don't get things like long-press detection, but we do still get feedback for key-in and key-out. We should do something better when we upstream keyboard behavior to do proper integration into the Pressability state machine, but this is invasive enough that we shouldn't fork this. Validated Spacebar and enter functionality with various touchables.
NickGerleman
commented
May 17, 2020
Comment on lines
+525
to
+529
| const mouseEventHandlers = | ||
| Platform.OS === 'ios' || Platform.OS === 'android' | ||
| ? null | ||
| : { | ||
| onMouseEnter: (event: MouseEvent): void => { |
Contributor
Author
There was a problem hiding this comment.
Curious to know what's going on here. We saw MouseEvent show up in 0.62, but IIRC didn't get an understanding of why. Wondering if they're being proactive for react-native-web?
Contributor
There was a problem hiding this comment.
I think FB uses pressablilty on web too. These events are not hooked up to anything in RN, and may be removed in the future. (It sounds like it was a bit of a mistake they ever got into RN in their current form)
NickGerleman
commented
May 17, 2020
Comment on lines
577
to
578
| // $FlowFixMe: PressEvents don't mesh with keyboarding APIs. Keep legacy behavior of pasing KeyEvents instead | ||
| onPressOut && onPressOut(event); |
Contributor
Author
There was a problem hiding this comment.
This is terrible of course 😉
All options involve some level of passing garbage unless we make upstream API changes unfortunately. This method of passing garbage is simple and the same as before though.
acoates-ms
approved these changes
May 18, 2020
NickGerleman
added
the
AutoMerge
|
Hello @NickGerleman! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
NickGerleman
added a commit
to NickGerleman/react-native-windows
that referenced
this pull request
May 19, 2020
…4930) * Implement Keybpoarding/Gamepad Activation for Pressability Fixes microsoft#4598 This change reenables touchables to be activated by keyboard/Gamepad. The implementation is mostly stolen from the previous that was used for Touchable. Like before, this doesn't participate in the input state machine, as its coupled to touch input. This means we don't get things like long-press detection, but we do still get feedback for key-in and key-out. We should do something better when we upstream keyboard behavior to do proper integration into the Pressability state machine, but this is invasive enough that we shouldn't fork this. Validated Spacebar and enter functionality with various touchables. * Change files * Flow fixes * Fix typo
NickGerleman
added a commit
that referenced
this pull request
May 19, 2020
* Implement Keybpoarding/Gamepad Activation for Pressability Fixes #4598 This change reenables touchables to be activated by keyboard/Gamepad. The implementation is mostly stolen from the previous that was used for Touchable. Like before, this doesn't participate in the input state machine, as its coupled to touch input. This means we don't get things like long-press detection, but we do still get feedback for key-in and key-out. We should do something better when we upstream keyboard behavior to do proper integration into the Pressability state machine, but this is invasive enough that we shouldn't fork this. Validated Spacebar and enter functionality with various touchables. * Change files * Flow fixes * Fix typo
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4598
This change reenables touchables to be activated by keyboard/Gamepad. The implementation is mostly stolen from the previous that was used for Touchable. This doesn't participate in the input state machine, as its coupled to touch input. This means we don't get things like long-press detection (whether we want that is questionable), but we do still get feedback for key-in and key-out.
We should do something better when we upstream keyboard behavior to do proper integration into the Pressability state machine, but this is invasive enough that we shouldn't fork this.
Validated Spacebar and enter functionality with various touchables.
Microsoft Reviewers: Open in CodeFlow