Update projects to use shared props/targets #4987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannyvv
force-pushed
the
pr/UpdateProjectsToUseTargetsAndProps
branch
4 times, most recently
from
a6614a0 to
fcce020
Compare
dannyvv
commented
May 27, 2020
packages/E2ETest/windows/ReactUWPTestApp/ReactUWPTestApp.csproj
Outdated
Show resolved
Hide resolved
dannyvv
changed the title
dannyvv
force-pushed
the
pr/UpdateProjectsToUseTargetsAndProps
branch
from
e381f1e to
20e1746
Compare
Member
|
Please add the PR description. |
vmoroz
reviewed
May 27, 2020
packages/microsoft-reactnative-sampleapps/windows/SampleAppCPP/SampleAppCpp.vcxproj
Outdated
Show resolved
Hide resolved
dannyvv
force-pushed
the
pr/UpdateProjectsToUseTargetsAndProps
branch
2 times, most recently
from
41e2962 to
761c518
Compare
vmoroz
reviewed
May 27, 2020
vnext/local-cli/generator-windows/templates/cpp/proj/MyApp.vcxproj
Outdated
Show resolved
Hide resolved
dannyvv
force-pushed
the
pr/UpdateProjectsToUseTargetsAndProps
branch
from
761c518 to
5c07fdd
Compare
asklar
reviewed
May 28, 2020
packages/microsoft-reactnative-sampleapps/windows/SampleLibraryCPP/SampleLibraryCPP.vcxproj
Outdated
Show resolved
Hide resolved
asklar
reviewed
May 28, 2020
vnext/PropertySheets/External/Microsoft.ReactNative.Common.props
Outdated
Show resolved
Hide resolved
asklar
approved these changes
May 28, 2020
Member
asklar
left a comment
asklar
left a comment
There was a problem hiding this comment.
only concern is the app/lib mismatch in sampleapplibrarycpp
dannyvv
force-pushed
the
pr/UpdateProjectsToUseTargetsAndProps
branch
from
5c07fdd to
4c25978
Compare
dannyvv
added
the
AutoMerge
|
Hello @dannyvv! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
dannyvv
force-pushed
the
pr/UpdateProjectsToUseTargetsAndProps
branch
4 times, most recently
from
5f2be83 to
cdc0712
Compare
dannyvv
force-pushed
the
pr/UpdateProjectsToUseTargetsAndProps
branch
from
cdc0712 to
d8f4177
Compare
ghost
merged commit 
NickGerleman
added
the
Breaking Change
Contributor
|
Adding the breaking change label since this modifies the template. |
Contributor
|
Adding backport as this change will now be required as a dependency for autolinking. I have to re-work auto-linking on top of these template changes, since they conflict. #5044 |
Contributor
|
Removing backport, autolinking will wait until 63. |
Contributor
|
@dannyvv Please make a corresponding issue in the docs repo to update the native module setup to include the new Lib.targets and props you've created here. (After the 62 releases and the website snaps to 62, so the changes will be ready for 63). |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates all our checked in apps and libraries to use our shared props and targets files. This is to have them match the template we have for react-native-init
Microsoft Reviewers: Open in CodeFlow