-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Adds a XamlUIService property to IReactContext, which exposes ElementFromTag #5034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
asklar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this WinUI 3 friendly :)
vmoroz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
|
Hello @acoates-ms! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 hours, a condition that will be fulfilled in about 8 hours 30 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Removing the |
|
Is this going to be back-ported? |
|
@stecrain - yes it is going to be back-ported. |
|
Approved for backport by triage |
…FromTag (microsoft#5034) * Add XamlUIService with ElementFromReactTag * formatting * Change files * XamlUIService shouldn't be part of desktop dll
There is currently no way to get to the XAML element from a reactTag -- which is something requested by several partners.
This creates a XamlUIService class that can be used to expose XAML specific functionality from a ReactContext. This new class exposes ElementFromReactTag which is the equivalent of the viewForReactTag method exposed on iOS. It also exposes DispatchEvent which is currently on ReactContext directly, but is planned to be deprecated from the current class, as we want ReactContext to be platform agnostic, allowing native modules to be sharable across platforms.
Sample usage based on example in the #4327:
Fixes #4327
Microsoft Reviewers: Open in CodeFlow