Skip to content

Conversation

@ZihanChen-MSFT
Copy link
Contributor

@ZihanChen-MSFT ZihanChen-MSFT commented May 28, 2020

  • Test cases added to Microsoft.ReactNative.ComponentTests
  • Test cases executed by writing thing to the writer, and then read them out of the reader
  • Dynamic* and Jsi* execute exactly the same set of test cases, to ensure that they behaves the same to each other.
Microsoft Reviewers: Open in CodeFlow

@ZihanChen-MSFT ZihanChen-MSFT requested a review from a team as a code owner May 28, 2020 21:59
@ZihanChen-MSFT ZihanChen-MSFT added the AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) label May 28, 2020
@ghost
Copy link

ghost commented May 28, 2020

Hello @ZihanChen-MSFT!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 hours. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ZihanChen-MSFT
Copy link
Contributor Author

I've seen several PRs have the issue of "license/cla Expected"

@asklar
Copy link
Member

asklar commented May 29, 2020

I've seen several PRs have the issue of "license/cla Expected"

sent mail asking 1es about this

@acoates-ms acoates-ms merged commit 8bbd689 into microsoft:master May 29, 2020
@dannyvv dannyvv linked an issue Jun 2, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement JSIReader/JSIWriter

4 participants