Skip to content

More attempts at making E2E test more reliable #5055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
acoates-ms merged 5 commits into from
Jun 1, 2020
Merged

More attempts at making E2E test more reliable #5055

acoates-ms merged 5 commits into from
Jun 1, 2020

Conversation

@acoates-ms
Copy link
Contributor

@acoates-ms acoates-ms commented May 29, 2020 •
edited
Loading

[Work in progress, will keep running CI to see if this helps things any]

  • Moved creation of errorShots directory to be part of the E2E script, so that error screenshots can be properly created when running the tests locally
  • Forced the app to run in light mode so that the tests pass locally when run on a machine that's in dark mode
  • Modified the TextInput test to view more events, since the order of the events is not guaranteed, and was causing some failures.
Microsoft Reviewers: Open in CodeFlow

@acoates-ms acoates-ms requested a review from a team as a code owner May 29, 2020 17:12
@acoates-ms
Copy link
Contributor Author

acoates-ms commented May 31, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented May 31, 2020

Azure Pipelines successfully started running 1 pipeline(s).

dannyvv
dannyvv approved these changes May 31, 2020
View reviewed changes
Copy link
Member

@dannyvv dannyvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@acoates-ms acoates-ms merged commit 0df2043 into microsoft:master Jun 1, 2020
@acoates-ms acoates-ms deleted the e2eh branch June 1, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dannyvv dannyvv dannyvv approved these changes

+1 more reviewer

@asklar asklar asklar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@acoates-ms @dannyvv @asklar