Skip to content

Conversation

@dannyvv
Copy link
Member

@dannyvv dannyvv commented Jun 12, 2020

Periodically there is a locking issue when building vnext/Microsoft.ReactNative.sln when building with flag /bl. This flag tells msbuild to construct a detailed binary log. As it is constructing the log it is creating a .zip file to contain all the build specs. In the solution the IntegrationTest project runs the metro bundler. This one tries to open the .zip file and gets a file access violationand fails the build.
This change adds it to the metro config's exclusion list so it won't try to read that zip file.

Microsoft Reviewers: Open in CodeFlow

@dannyvv dannyvv requested a review from a team as a code owner June 12, 2020 00:02
@dannyvv dannyvv requested review from asklar and vmoroz June 12, 2020 00:02
@dannyvv dannyvv added the AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) label Jun 12, 2020
@ghost
Copy link

ghost commented Jun 12, 2020

Hello @dannyvv!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 hours. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link
Contributor

@kmelmon kmelmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@asklar
Copy link
Member

asklar commented Jun 12, 2020

@dannyvv I thought I had fixed these with #5050 - did I miss this one?

@dannyvv
Copy link
Member Author

dannyvv commented Jun 12, 2020

@dannyvv Danny van Velzen FTE I thought I had fixed these with #5050 - did I miss this one?

@asklar You correctly did all the apps, but it turns out our main solution runs a 'test' app in the inetegration test (npx spawned from msbuild to construct the bundle through custom targets) that picks up the metro-config in /vnext. You'd only see it if you locally run msbuild in the vnext folder with /bl. The CI builds it from the root giving msbuild a relative path so the zip file is written to the root of the enlistmnet outside of the purvue of the bundler.

@dannyvv dannyvv force-pushed the pr/FixMetroVNext branch from ce9df88 to 40dc337 Compare June 12, 2020 04:50
@ghost ghost merged commit 3945737 into microsoft:master Jun 12, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants