WinUI 3/islands support #5576
Merged
WinUI 3/islands support #5576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Playground Win32 - start getting it working on WinUI 3 * Change files * use lifted DWXS * DWXS header * create separate 16.7 packaging solution * format * fix non-winui3 case * use CI nuget downloaded and expanded to C:\temp * preprocessor defines * Port to WinUI 3 dev nuget with IXP payload (almost preview 2). Islands are rendering! * hosting namespace * Playground Win32 - start getting it working on WinUI 3 * DWXS header * create separate 16.7 packaging solution * format * guard against hresult (from failed activation) in UIManager, update reference to winui.props in WAP * Playground Win32 - start getting it working on WinUI 3 * DWXS header * create separate 16.7 packaging solution * format * Port to WinUI 3 dev nuget with IXP payload (almost preview 2). Islands are rendering! * Playground Win32 - start getting it working on WinUI 3 * use lifted DWXS * DWXS header * create separate 16.7 packaging solution * format * guard against hresult (from failed activation) in UIManager, update reference to winui.props in WAP * Playground Win32 - start getting it working on WinUI 3 * DWXS header * create separate 16.7 packaging solution * format * Port to WinUI 3 dev nuget with IXP payload (almost preview 2). Islands are rendering!
* Playground Win32 - start getting it working on WinUI 3 * Change files * use lifted DWXS * DWXS header * create separate 16.7 packaging solution * format * fix non-winui3 case * use CI nuget downloaded and expanded to C:\temp * preprocessor defines * Port to WinUI 3 dev nuget with IXP payload (almost preview 2). Islands are rendering! * hosting namespace * Playground Win32 - start getting it working on WinUI 3 * DWXS header * create separate 16.7 packaging solution * format * guard against hresult (from failed activation) in UIManager, update reference to winui.props in WAP * Playground Win32 - start getting it working on WinUI 3 * DWXS header * create separate 16.7 packaging solution * format * Port to WinUI 3 dev nuget with IXP payload (almost preview 2). Islands are rendering! * Playground Win32 - start getting it working on WinUI 3 * use lifted DWXS * DWXS header * create separate 16.7 packaging solution * format * guard against hresult (from failed activation) in UIManager, update reference to winui.props in WAP * Playground Win32 - start getting it working on WinUI 3 * DWXS header * create separate 16.7 packaging solution * format * Port to WinUI 3 dev nuget with IXP payload (almost preview 2). Islands are rendering!
asklar
added
Area: Islands
Area: WinUI
AutoMerge
|
Hello @asklar! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 hours, a condition that will be fulfilled in about 1 hour 55 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
vmoroz
reviewed
Jul 24, 2020
vmoroz
reviewed
Jul 24, 2020
vmoroz
reviewed
Jul 24, 2020
vmoroz
reviewed
Jul 24, 2020
vmoroz
reviewed
Jul 24, 2020
vmoroz
reviewed
Jul 24, 2020
| @@ -0,0 +1,13 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
Member
There was a problem hiding this comment.
Could we avoid having spaces in the folder and file names? Many tools will fail to work. Especially if they originally created for Unix-like OSes.
Member
Author
There was a problem hiding this comment.
@vmoroz can you clarify what tools created for Unix might have to deal with a Windows app packaging project?
vmoroz
reviewed
Jul 24, 2020
packages/playground/windows/playground-win32/Playground-win32.vcxproj
Outdated
Show resolved
Hide resolved
vmoroz
reviewed
Jul 24, 2020
packages/playground/windows/playground-win32/Playground-Win32.h
Outdated
Show resolved
Hide resolved
vmoroz
reviewed
Jul 24, 2020
packages/playground/windows/playground-win32/Playground-Win32.h
Outdated
Show resolved
Hide resolved
rectified95
approved these changes
Jul 30, 2020
ghost
merged commit 
10 tasks
2 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relies on bits that will only be available publicly via WinUI 3 preview 3, so for now I'm using a nuget package from CI.
All of the changes are usable with system xaml and winui 3 preview 2 except for one in
TouchEventHandler(since the IXP apis are changing), so that one change is behind aWINUI3_PREVIEW3preprocessor define.The facebook api for native UI manager has a fixed set of exception types it handles, and obviously those don't include
winrt::hresult_error, so when a WinRT type activation fails, ahresult_erroris thrown and goes unhandled crashing the whole process, so adding a conversion fromhresult_errorto the error message so that the frame that's lower in the stack handles it (since it catches among a few other things,std::strings).I'm also including a script to transform packages.config and winui.props automatically based on a new nuget package.
Microsoft Reviewers: Open in CodeFlow