Skip to content

Conversation

@rectified95
Copy link
Contributor

@rectified95 rectified95 commented Sep 9, 2020

Commits: https://github.com/facebook/react-native/compare/e75557b48..a36d9cd7e

  • Removed Windows fork of PlatformColorExample.js
  • Added partially-working Windows implementation of GetValue() in NativeAnimatedModule; this change was introduced in RN to allow the caching of animation values in JS code, in case a node gets unmounted and remounted in the tree; including a best-effort implementation for Windows, which cannot inspect values during an ongoing animation.

Added

Android specific

Removed

  • Removed once() and removeCurrentListener() fom DeviceEventEmitter and NativeEventEmitter. (87a2e29f59 by @yungsters)

Fixed

  • Fix: Preserve native animated value after animated component unmount (d92284216f by @TMaszko)

Android specific

Unknown

  • Daily arc lint --take GOOGLEJAVAFORMAT (df6d2c50ff)

Failed to parse

Microsoft Reviewers: Open in CodeFlow

@rectified95 rectified95 requested a review from a team as a code owner September 9, 2020 22:28
@NickGerleman
Copy link
Contributor

This is awesome. I looked through commits earlier, and think the Animated change was the only thing we were missing.

A couple of quick questions:

  1. There are some new RNTester examples for Animated using the new API. So we know if our best-effort implementation ends up showing something sane here (even if not correct)?
  2. Could we file an issue with the details around the missing functionality for Animated? For APIs we can't implement using System XAML, some of them have turned into asks for WinUI3

@rectified95
Copy link
Contributor Author

rectified95 commented Sep 9, 2020

@NickGerleman
re 1: The Animated example shows the caching in action. While we cannot preserve the value of a component unmounted while it was being animated, we successfully preserve the value from the end of animation, once it completed - that was my definition of best-effort, since we do succeed in that case because when an element is readded into the UI tree, it's placed in the animation's target position.
re 2: filed issue #5958

Copy link
Contributor

@NickGerleman NickGerleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off, but you'll need to pull in the change to Text.js

NickGerleman and others added 2 commits September 10, 2020 10:49
Implement partially working GetValue() in NativeAnimatedModule.

pull in missing change in Text.js
@rectified95
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rectified95
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rectified95 rectified95 merged commit 8922cf2 into microsoft:master Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants