Skip to content

Self-signed certificate - timeout error fix #6646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dannyvv merged 4 commits into from
Dec 2, 2020
Merged

Self-signed certificate - timeout error fix #6646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7205e85
Enhance the generateCertificate error result
BartoszKlonowski Dec 1, 2020
c4aab1c
Remove the timeout from self-signed certificate generating
BartoszKlonowski Dec 1, 2020
aad7f4b
Change files
BartoszKlonowski Dec 2, 2020
495bb44
Fix code formatting
BartoszKlonowski Dec 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@react-native-windows-cli-4be26f48-0076-4686-9fb4-6fe14a114393.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "Remove the timeout from self-signed certificate generating",
"packageName": "@react-native-windows/cli",
"email": "Bartosz.Klonowski@callstack.com",
"dependentChangeType": "patch"
}
8 changes: 4 additions & 4 deletions packages/@react-native-windows/cli/src/generator-windows/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,9 @@ async function generateCertificate(
console.log('Generating self-signed certificate...');
if (os.platform() === 'win32') {
try {
const timeout = 10000; // 10 seconds;
const thumbprint = childProcess
.execSync(
`powershell -NoProfile -Command "Write-Output (New-SelfSignedCertificate -KeyUsage DigitalSignature -KeyExportPolicy Exportable -Subject 'CN=${currentUser}' -TextExtension @('2.5.29.37={text}1.3.6.1.5.5.7.3.3', '2.5.29.19={text}Subject Type:End Entity') -CertStoreLocation 'Cert:\\CurrentUser\\My').Thumbprint"`,
{timeout},
)
.toString()
.trim();
Expand All @@ -51,14 +49,16 @@ async function generateCertificate(
newProjectName,
newProjectName,
)}_TemporaryKey.pfx -Password $pwd"`,
{timeout},
);
console.log(
chalk.green('Self-signed certificate generated successfully.'),
);
return thumbprint;
} catch (err) {
console.log(chalk.yellow('Failed to generate Self-signed certificate.'));
console.log(
chalk.yellow('Unable to generate the self-signed certificate:'),
);
console.log(chalk.red(err));
}
}

Expand Down