Restore some SDL warnings (first pass)

[asklar]

Removes some "disable warnings" that are not needed. These warnings are required per SDL.

• C4018 - 'expression' : signed/unsigned mismatch
• C4146 - unary minus operator applied to unsigned type, result still unsigned
• C4995 - 'function': name was marked as #pragma deprecated

Microsoft Reviewers: Open in CodeFlow

[ghost]

Hello @asklar!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[rectified95]

Will these warnings show up now (or not since they're 'not needed')? If so should we create tasks to fix them?

[asklar]

Will these warnings show up now (or not since they're 'not needed')? If so should we create tasks to fix them?

@rectified95 no, these are warnings that were disabled but we don't have any code that triggers them now, maybe we used to :)

[NickGerleman]

Just to be sure, do we know if the warnings are currently enabled in this repo? Some of the code has history in other repos, which might have slightly different configuration for detecting anything opt-in.

[asklar]

Just to be sure, do we know if the warnings are currently enabled in this repo? Some of the code has history in other repos, which might have slightly different configuration for detecting anything opt-in.

Warnings are enabled, and we have 267 of them right now. It's just that these ones I'm removing aren't being triggered.

[NickGerleman]

I think some of these may be off by default, even at /W4.

• https://docs.microsoft.com/en-us/cpp/build/reference/compiler-option-warning-level?view=msvc-160
• https://docs.microsoft.com/en-us/cpp/preprocessor/compiler-warnings-that-are-off-by-default?view=msvc-160

Would be great to do a sanity check. Like, seeing if it's picked up with /Wall, or creating some code that what violate the error and see if it's caught.

I think some different projects may also have different settings for warnings as errors. I remember some work in that area last year but don't remember outcomes.

[NickGerleman]

Looks like these don't show up in the off by default list. Signing off.

[aschultz]

@asklar @NickGerleman Any chance we can get this backported to 0.63/0.64?