Fix announceForAccessibility #7220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
rectified95
approved these changes
Feb 25, 2021
| element = xamlRoot.Content(); | ||
| } | ||
| } | ||
| auto textBlock = xaml::Controls::TextBlock(); |
Contributor
There was a problem hiding this comment.
nit: seems like a UIElement might be enough - https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.automation.peers.frameworkelementautomationpeer.fromelement?view=winrt-19041
Would be a little cheaper to create - can you try that?
Member
There was a problem hiding this comment.
you can't instantiate UIElement directly, only subclasses
Contributor
Author
There was a problem hiding this comment.
Should I leave it as is? Or is there a cheaper subclass I should instantiate instead?
Contributor
There was a problem hiding this comment.
I think it might work with a Control
Contributor
Author
There was a problem hiding this comment.
Ok looks like Control also can't be instantiated directly only its subclasses.
rozele
pushed a commit
to rozele/react-native-windows
that referenced
this pull request
Oct 6, 2021
Summary: Cherry picks: microsoft#5849 microsoft#7220 microsoft#7290 Test Plan: See D29689294 Test Plan Reviewers: ericroz Reviewed By: ericroz Subscribers: eliwhite Differential Revision: https://phabricator.intern.facebook.com/D30940769 Tasks: T85606613 Signature: 30940769:1631724353:41db1d978132f06502803cfb4df0323f6da84732
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #5908
Why
announceForAccessibility method in the AccessibilityInfo module failed to announce messages.
What
The API for the method does not include a reference to a RN component as a parameter but Windows requires an element to announce from. The previous implementation tried to pass in Xaml::Window::Content into FrameworkElementAutomationPeer::FromElement to create an automation peer, but this approach always resulted in the peer being null and no announcement could be made.
Altered the code such that a Xaml Control (TextBlock) is passed into FrameworkElementAutomationPeer::FromElement instead. This caused the peer returned to be non-null and the announcement could be fired.
Testing
Created an RNW app and altered Microsoft.ReactNative inside of tester app with the changes to AccessibilityInfo. Was able to hear announcement when announceForAccessibility was called.
Microsoft Reviewers: Open in CodeFlow