Skip to content

Conversation

@vmoroz
Copy link
Member

@vmoroz vmoroz commented Mar 15, 2021

In this PR we update contents and formatting of the DOC_STRINGs in IDL files.
They are used to generate docs for the ABI-safe API docs.
The PR covers changes to the following files:

  • IReactContext.idl
  • IReactDispatcher.idl
  • IReactModuleBuilder.idl
  • IReactNonAbiValue.idl
  • IReactNotificationService.idl
  • IReactPackageBuilder.idl
  • IReactPackageProvbider.idl
  • IReactPropertyBag.idl
  • JsiApi.idl
  • QuirkSettings.idl
  • ReactApplication.idl
  • ReactInstanceSettings.idl
  • ReactNativeHost.idl
  • ReactRootView.idl
  • RedBoxHandler.idl
  • XamlHelper.idl
  • XamlUIService.idl
Microsoft Reviewers: Open in CodeFlow

@vmoroz vmoroz requested review from acoates-ms, asklar and stmoy March 15, 2021 22:01
@vmoroz vmoroz requested a review from a team as a code owner March 15, 2021 22:01
@vmoroz vmoroz marked this pull request as draft March 15, 2021 22:01
@vmoroz vmoroz marked this pull request as ready for review March 17, 2021 01:36
@vmoroz vmoroz changed the title [DRAFT] Updates to documentation in IDL files Updates to documentation in IDL files Mar 17, 2021
Copy link
Member

@asklar asklar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marking request changes to fix some of the typos/add links so this doesn't accidentally get merged before time

@ghost ghost added Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) and removed Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) labels Mar 17, 2021
@vmoroz vmoroz added the AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) label Mar 18, 2021
@ghost
Copy link

ghost commented Mar 18, 2021

Hello @vmoroz!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants