Integrate April 1 RN nightly build. #7580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickGerleman
changed the title
rectified95
force-pushed
the
integrate_apr_1
branch
2 times, most recently
from
b4c7acb to
ee93cae
Compare
rectified95
force-pushed
the
integrate_apr_1
branch
from
807c5b7 to
102dda5
Compare
Contributor
|
Will look through this today. |
dannyvv
approved these changes
Apr 15, 2021
NickGerleman
approved these changes
Apr 15, 2021
Contributor
NickGerleman
left a comment
NickGerleman
left a comment
There was a problem hiding this comment.
Skimmed through the upstream commits. LGTM
dannyvv
reviewed
Apr 15, 2021
|
|
||
| MapBufferBuilder::MapBufferBuilder(uint16_t initialSize) { | ||
| keyValuesSize_ = initialSize; | ||
| keyValues_ = new Byte[keyValuesSize_]; |
Member
There was a problem hiding this comment.
@rectified95 : I know this is from fb, but shouldn't this code be backed by a std::vector just to reduce risk of memory excurions?
Contributor
Author
There was a problem hiding this comment.
@dannyvv The MapBuffer class has a bunch of potential issues, and the most we can do is submit PRs changing it - otherwise we take it 'as is' from core. (btw what's a memory excursion? There's some custom resize/allocation code in there, if that's what it means.) I think its goal is to be faster than STL.
I'll remove this file once the core PR is merged and we ingest it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits: facebook/react-native@cfb5b5e...d04ec4d
vnext/ReactCommon/ReactCommon.vcxprojforTransactionTelemetryTestnew location.AccessibilityInfo.SendAccessibilityEventto align with facebook/react-native@eacc940MapBufferdue to a build break in VS (we treat missing cast warnings as errors). Tracking removal with: Remove fork of MapBufferBuilder.cpp #7591. PR in core fixing this: Add explicit type casts to fix compilation errors on Windows. facebook/react-native#31363Microsoft Reviewers: Open in CodeFlow