Add Text component RNTester page treedump tests. #7735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rectified95
changed the title
NickGerleman
reviewed
May 6, 2021
NickGerleman
reviewed
May 6, 2021
NickGerleman
reviewed
May 6, 2021
rectified95
force-pushed
the
add_text_test
branch
from
3368595 to
72cfd1e
Compare
rectified95
changed the title
rectified95
force-pushed
the
add_text_test
branch
from
72cfd1e to
dadad1d
Compare
Contributor
Author
|
@NickGerleman Let me know if is this more like what you had in mind :) |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LegacyTextBackgroundColorTest, as this is now included in the dump of the entire page.Direct motivation for this is to test a small change to the text transform algorithm I'm making - once this is checked in, we'll be sure that PR won't break things.
I've been meaning to add tests for all view managers - this is the start of that. It will probably involve a modification to
visitAllPagesso that it dumps VM pages.Microsoft Reviewers: Open in CodeFlow