[NativeAnimated][3/3] Adds NativeAnimated value listeners for rendering driven events #9286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
rozele
changed the title
rozele
changed the title
rozele
changed the title
Contributor
Author
|
Merged into #9249 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Why
The Animated APIs support the attachment of value listeners for various use cases, but the current UI.Composition APIs do not accommodate this.
This change is functionally dependent on #9249, which introduces the option to run native animations on the UI thread via CompositionTarget::Rendering callbacks.
Resolves #4311
What
Extends the ValueAnimatedNode with a callback that is invoked after calling
OnValueUpdated(this occurs in the rendering driver in #9249). The callback is wired up to theNativeAnimatedModule, which callsRCTDeviceEventEmitter.emit("onAnimatedValueUpdate", { value: X });.Testing
Will attach before and after videos.
Microsoft Reviewers: Open in CodeFlow