Use raw value for CalculatedAnimationDriver #9367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rozele
force-pushed
the
nativeAnimatedFix
branch
2 times, most recently
from
c7c2020 to
a43a80e
Compare
The fixes to change from animating the offset property to the value property missed a minor bug in CalculatedAnimationDriver, where we start the animation from the `Value` of the animated value node rather than the `RawValue`. This generally won't cause any bugs for animations that do not use the `Offset` property (via `setOffset`), as in those cases `Value` == `RawValue`.
rozele
force-pushed
the
nativeAnimatedFix
branch
from
a43a80e to
4b25c4b
Compare
NickGerleman
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Erase all that don't apply.
Why
There was a minor bug in the CalculationAnimationDriver that accounted for the value node offset when getting the start value for the animation. Animation drivers should always start from the raw value.
What
The fixes to change from animating the offset property to the value property (#9302) missed a minor bug in CalculatedAnimationDriver, where we start the animation from the
Valueof the animated value node rather than theRawValue. This generally won't cause any bugs for animations that do not use theOffsetproperty (viasetOffset), as in those casesValue==RawValue.Testing
Re-ran RNTester NativeAnimated scenarios and they work as before (no change). Also verified that the native animation behavior diverged when using
setOffsetand no longer diverges with this fix.Here's the before:
playground.2022-01-11.10-36-13.mp4
Here's the after:
playground.2022-01-11.10-37-55.mp4
Microsoft Reviewers: Open in CodeFlow