Implement IHttpResource

change/react-native-windows-7bb307e0-b40f-48f0-a356-a43c860eeefb.json

@@ -0,0 +1,7 @@
+{
+  "type": "prerelease",
+  "comment": "Implement IHttpResource",
+  "packageName": "react-native-windows",
+  "email": "julio.rocha@microsoft.com",
+  "dependentChangeType": "patch"
+}

vnext/Desktop.DLL/react-native-win32.x64.def

@@ -59,7 +59,7 @@ EXPORTS
 ?GetRuntimeOptionBool@React@Microsoft@@YA?B_NAEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z
 ?GetRuntimeOptionInt@React@Microsoft@@YA?BHAEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z
 ?makeChakraRuntime@JSI@Microsoft@@YA?AV?$unique_ptr@VRuntime@jsi@facebook@@U?$default_delete@VRuntime@jsi@facebook@@@std@@@std@@$$QEAUChakraRuntimeArgs@12@@Z
-?Make@IHttpResource@React@Microsoft@@SA?AV?$unique_ptr@UIHttpResource@React@Microsoft@@U?$default_delete@UIHttpResource@React@Microsoft@@@std@@@std@@XZ
+?Make@IHttpResource@React@Microsoft@@SA?AV?$shared_ptr@UIHttpResource@React@Microsoft@@@std@@XZ
 ?CreateTimingModule@react@facebook@@YA?AV?$unique_ptr@VCxxModule@module@xplat@facebook@@U?$default_delete@VCxxModule@module@xplat@facebook@@@std@@@std@@AEBV?$shared_ptr@VMessageQueueThread@react@facebook@@@4@@Z
 ??0WebSocketModule@React@Microsoft@@QEAA@XZ
 ??0NetworkingModule@React@Microsoft@@QEAA@XZ

vnext/Desktop.DLL/react-native-win32.x86.def

@@ -60,7 +60,7 @@ EXPORTS
 ?makeChakraRuntime@JSI@Microsoft@@YG?AV?$unique_ptr@VRuntime@jsi@facebook@@U?$default_delete@VRuntime@jsi@facebook@@@std@@@std@@$$QAUChakraRuntimeArgs@12@@Z
 ?CreateTimingModule@react@facebook@@YG?AV?$unique_ptr@VCxxModule@module@xplat@facebook@@U?$default_delete@VCxxModule@module@xplat@facebook@@@std@@@std@@ABV?$shared_ptr@VMessageQueueThread@react@facebook@@@4@@Z
 ??0WebSocketModule@React@Microsoft@@QAE@XZ
-?Make@IHttpResource@React@Microsoft@@SG?AV?$unique_ptr@UIHttpResource@React@Microsoft@@U?$default_delete@UIHttpResource@React@Microsoft@@@std@@@std@@XZ
+?Make@IHttpResource@React@Microsoft@@SG?AV?$shared_ptr@UIHttpResource@React@Microsoft@@@std@@XZ
 ??0NetworkingModule@React@Microsoft@@QAE@XZ
 ?MakeJSQueueThread@ReactNative@Microsoft@@YG?AV?$shared_ptr@VMessageQueueThread@react@facebook@@@std@@XZ
 ?Hash128@SpookyHashV2@hash@folly@@SGXPBXIPA_K1@Z

vnext/Desktop.IntegrationTests/DesktopTestRunner.cpp

@@ -50,14 +50,6 @@ shared_ptr<ITestInstance> TestRunner::GetInstance(
        },
        nativeQueue},
 
-      {"WebSocketModule", []() -> unique_ptr<CxxModule> { return std::make_unique<WebSocketModule>(); }, nativeQueue},
-
-      {"Networking",
-       []() -> unique_ptr<CxxModule> { return std::make_unique<Microsoft::React::NetworkingModule>(); },
-       nativeQueue},
-
-      {"Timing", [nativeQueue]() -> unique_ptr<CxxModule> { return CreateTimingModule(nativeQueue); }, nativeQueue},
-
       // Apparently mandatory for /IntegrationTests
       {TestAppStateModule::name,
        []() -> unique_ptr<CxxModule> { return std::make_unique<TestAppStateModule>(); },

vnext/Desktop.IntegrationTests/HttpResourceIntegrationTests.cpp

@@ -1,47 +1,163 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
+// C4996: 'gethostbyaddr': Use getnameinfo() or GetNameInfoW() instead
+#define _WINSOCK_DEPRECATED_NO_WARNINGS
+
 #include <CppUnitTest.h>
 #include <IHttpResource.h>
+#include <Test/HttpServer.h>
+#include <boost/beast/http.hpp>
+#include <unicode.h>
+
+// Standard Library
+#include <future>
 
 using namespace Microsoft::React;
-using namespace folly;
 using namespace Microsoft::VisualStudio::CppUnitTestFramework;
 
+namespace http = boost::beast::http;
+
+using std::promise;
 using std::string;
 using std::vector;
 
 TEST_CLASS (HttpResourceIntegrationTest) {
-  TEST_METHOD(MakeIsNotNull) {
-    auto rc = IHttpResource::Make();
-    Assert::IsFalse(nullptr == rc);
+  TEST_METHOD(RequestGetSucceeds) {
+    promise<void> promise;
+    string error;
+    int statusCode = 0;
+
+    // HTTP call scope
+    {
+      auto server = std::make_shared<Test::HttpServer>("127.0.0.1", static_cast<uint16_t>(5556));
+      server->SetOnGet([](const http::request<http::string_body> &request) -> http::response<http::dynamic_body> {
+        http::response<http::dynamic_body> response;
+        response.result(http::status::ok);
+
+        return response;
+      });
+      server->Start();
+
+      auto resource = IHttpResource::Make();
+      resource->SetOnResponse([&promise, &statusCode](int64_t, IHttpResource::Response response) {
+        statusCode = static_cast<int>(response.StatusCode);
+        promise.set_value();
+      });
+      resource->SetOnError([&promise, &error, &server](int64_t, string &&message) {
+        error = std::move(message);
+        promise.set_value();
+
+        server->Abort();
+      });
+      resource->SendRequest(
+          "GET",
+          "http://localhost:5556",
+          {} /*header*/,
+          {} /*bodyData*/,
+          "text",
+          false,
+          1000 /*timeout*/,
+          false /*withCredentials*/,
+          [](int64_t) {});
+
+      server->Stop();
+    }
+    // Synchronize response.
+    promise.get_future().wait();
+
+    Assert::AreEqual({}, error);
+    Assert::AreEqual(200, statusCode);
   }
 
-  // This test always fails because the requested resource does not exist.
-  // TEST_METHOD(RequestGetSucceeds) {
-  void Disable_RequestGetSucceeds() {
-    auto rc = IHttpResource::Make();
-    bool sent = false;
-    bool received = false;
+  TEST_METHOD(RequestGetHeadersSucceeds) {
+    promise<void> promise;
     string error;
-    rc->SetOnRequest([&sent]() { sent = true; });
-    rc->SetOnResponse([&received](const string &message) { received = true; });
-    rc->SetOnError([&error](const string &message) { error = message; });
+    IHttpResource::Response response;
 
-    rc->SendRequest("GET", "http://localhost:8081/debugger-ui", {}, dynamic(), "text", false, 1000, [](int64_t) {});
+    // HTTP call scope
+    {
+      auto server = std::make_shared<Test::HttpServer>("127.0.0.1", static_cast<uint16_t>(5555));
+      server->SetOnGet([](const http::request<http::string_body> &request) -> http::response<http::dynamic_body> {
+        http::response<http::dynamic_body> response;
+        response.result(http::status::ok);
 
-    Assert::IsTrue(sent);
-    Assert::IsTrue(received);
-    Assert::AreEqual(string(), error);
+        // Response header
+        response.set(http::field::server, "Microsoft::React::Test::HttpServer");
+        // Response content header
+        response.set(http::field::content_length, "0");
+        // Response arbitrary header
+        response.set("ResponseHeaderName1", "ResponseHeaderValue1");
+
+        return response;
+      });
+      server->Start();
+
+      auto resource = IHttpResource::Make();
+      resource->SetOnResponse([&promise, &response](int64_t, IHttpResource::Response callbackResponse) {
+        response = callbackResponse;
+        promise.set_value();
+      });
+      resource->SetOnError([&promise, &error, &server](int64_t, string &&message) {
+        error = std::move(message);
+        promise.set_value();
+
+        server->Abort();
+      });
+
+      //clang-format off
+      resource->SendRequest(
+          "GET",
+          "http://localhost:5555",
+          {
+              {"Content-Type", "application/json"},
+              {"Content-Encoding", "ASCII"},
+              {"name3", "value3"},
+              {"name4", "value4"},
+          },
+          {} /*bodyData*/,
+          "text",
+          false,
+          1000 /*timeout*/,
+          false /*withCredentials*/,
+          [](int64_t) {});
+      //clang-format on
+
+      server->Stop();
+    }
+
+    promise.get_future().wait();
+
+    Assert::AreEqual({}, error, L"Error encountered");
+    for (auto header : response.Headers) {
+      if (header.first == "Server") {
+        Assert::AreEqual({"Microsoft::React::Test::HttpServer"}, header.second, L"Wrong header");
+      } else if (header.first == "Content-Length") {
+        Assert::AreEqual({"0"}, header.second, L"Wrong header");
+      } else if (header.first == "ResponseHeaderName1") {
+        Assert::AreEqual({"ResponseHeaderValue1"}, header.second, L"Wrong header");
+      } else {
+        string message = "Unexpected header: [" + header.first + "]=[" + header.second + "]";
+        Assert::Fail(Microsoft::Common::Unicode::Utf8ToUtf16(message).c_str());
+      }
+    }
   }
 
   TEST_METHOD(RequestGetFails) {
-    auto rc = IHttpResource::Make();
     string error;
-    rc->SetOnError([&error](const string &message) { error = message; });
+    promise<void> promise;
+
+    auto resource = IHttpResource::Make();
+    resource->SetOnError([&error, &promise](int64_t, string &&message) {
+      error = message;
+      promise.set_value();
+    });
+
+    resource->SendRequest("GET", "http://nonexistinghost", {}, {}, "text", false, 1000, false, [](int64_t) {});
 
-    rc->SendRequest("GET", "http://nonexistinghost", {}, dynamic(), "text", false, 1000, [](int64_t) {});
+    promise.get_future().wait();
 
-    Assert::AreEqual(string("No such host is known"), error);
+    Logger::WriteMessage(error.c_str());
+    Assert::AreNotEqual(string{}, error);
   }
 };

vnext/Desktop.IntegrationTests/RNTesterIntegrationTests.cpp

@@ -23,11 +23,14 @@ std::wstring ToString<TestStatus>(const TestStatus &status) {
 } // namespace Microsoft::VisualStudio::CppUnitTestFramework
 
 TEST_MODULE_INITIALIZE(InitModule) {
-  Microsoft::React::SetRuntimeOptionBool("WebSocket.AcceptSelfSigned", true);
-  Microsoft::React::SetRuntimeOptionBool("UseBeastWebSocket", false);
+  using Microsoft::React::SetRuntimeOptionBool;
+
+  SetRuntimeOptionBool("WebSocket.AcceptSelfSigned", true);
+  SetRuntimeOptionBool("UseBeastWebSocket", false);
+  SetRuntimeOptionBool("Http.UseMonolithicModule", false);
 
   // WebSocketJSExecutor can't register native log hooks.
-  Microsoft::React::SetRuntimeOptionBool("RNTester.UseWebDebugger", false);
+  SetRuntimeOptionBool("RNTester.UseWebDebugger", false);
 }
 
 TEST_CLASS (RNTesterIntegrationTests) {

vnext/Desktop.IntegrationTests/React.Windows.Desktop.IntegrationTests.vcxproj

@@ -125,4 +125,4 @@
   <Target Name="Test">
     <Exec Command="$(OutDir)$(TargetFileName)" IgnoreStandardErrorWarningFormat="true" />
   </Target>
-</Project>
+</Project>