Set ResolveNuGetPackages in external props #9628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
JunielKatarn
added a commit
to jurocha-ms/react-native-windows
that referenced
this pull request
Mar 2, 2022
* Set ResolveNuGetPackages in external props * Change files * Move changes to Microsoft.ReactNative.Common.props
ghost
pushed a commit
that referenced
this pull request
Mar 6, 2022
* Set ResolveNuGetPackages in external props (#9628) * Set ResolveNuGetPackages in external props * Change files * Move changes to Microsoft.ReactNative.Common.props * Change files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set MSBuild property
ResolveNuGetPackagestofalsefor projects consuming MSRN.Type of Change
Why
External projects will fail to build due to
PackageReferenceon C++ not being compatible with propertyResolveNuGetPackages.Resolves #9512
What
Sets MSBuild property
ResolveNuGetPackagestofalse. Seevnext\PropertySheets\External\Microsoft.ReactNative.Common.props.Microsoft Reviewers: Open in CodeFlow