.Net: Processes: Hook up uninitialization for Steps in Local Runtime#10825
Merged
esttenorio merged 10 commits intomicrosoft:mainfrom Mar 13, 2025
Merged
Conversation
github-actions
Bot
changed the title
crickman
reviewed
Mar 6, 2025
alliscode
reviewed
Mar 7, 2025
alliscode
reviewed
Mar 10, 2025
esttenorio
had a problem deploying
to
integration
GitHub Actions
Failure
esttenorio
had a problem deploying
to
integration
GitHub Actions
Failure
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
crickman
approved these changes
Mar 13, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 13, 2025
…10825) ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> In Processes, in Local Runtime, there is currently no equivalent of `OnDeactivateAsync`(in dapr actors). Adding hook up to have this functionality in Steps in LocalRuntime. This hookup also allows properly supporting graceful uninitialization in the new ProxyStep components to close properly connections/clean up resources Fixes #10282 ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-project-automation
Bot
moved this from Backlog
to Sprint: Done
in Semantic Kernel
Member
|
@esttenorio @markwallace-microsoft
|
jcruzmot-te
pushed a commit
to thousandeyes/aia-semantic-kernel
that referenced
this pull request
Sep 15, 2025
…icrosoft#10825) ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> In Processes, in Local Runtime, there is currently no equivalent of `OnDeactivateAsync`(in dapr actors). Adding hook up to have this functionality in Steps in LocalRuntime. This hookup also allows properly supporting graceful uninitialization in the new ProxyStep components to close properly connections/clean up resources Fixes microsoft#10282 ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In Processes, in Local Runtime, there is currently no equivalent of
OnDeactivateAsync(in dapr actors).Adding hook up to have this functionality in Steps in LocalRuntime.
This hookup also allows properly supporting graceful uninitialization in the new ProxyStep components to close properly connections/clean up resources
Fixes #10282
Contribution Checklist