.Net: don't use a mutable static counter for tests that can run in parallel#11004
Merged
adamsitnik merged 1 commit intomicrosoft:mainfrom Mar 18, 2025
Merged
Conversation
github-actions
Bot
changed the title
dmytrostruk
approved these changes
Mar 17, 2025
markwallace-microsoft
approved these changes
Mar 18, 2025
jcruzmot-te
pushed a commit
to thousandeyes/aia-semantic-kernel
that referenced
this pull request
Sep 15, 2025
…rallel (microsoft#11004) By default, xUnit runs tests in parallel. What we were doing so far was having a static, mutable counter that some tests were setting to 0, while other could use in the meantime (increment or read and assert). I've changed it to use a static dictionary of counters, where the name of the step is the key. So each step has it's own counter. fixes microsoft#11001
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, xUnit runs tests in parallel. What we were doing so far was having a static, mutable counter that some tests were setting to 0, while other could use in the meantime (increment or read and assert).
I've changed it to use a static dictionary of counters, where the name of the step is the key. So each step has it's own counter.
fixes #11001