Skip to content

.Net: Fix unstable {Azure}OpenAI telemetry UT #11093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markwallace-microsoft merged 1 commit into from
Mar 20, 2025
Merged

.Net: Fix unstable {Azure}OpenAI telemetry UT #11093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions dotnet/src/Connectors/Connectors.AzureOpenAI.UnitTests/KernelCore/KernelTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,16 @@ public async Task FunctionUsageMetricsAreCapturedByTelemetryAsExpected()
}
});

var completed = false;

listener.MeasurementsCompleted = (instrument, state) =>
{
completed = true;
// Stop the listener to stop collecting data
Assert.Contains(12, measurements["semantic_kernel.function.invocation.token_usage.prompt"]);
Assert.Contains(5, measurements["semantic_kernel.function.invocation.token_usage.completion"]);
};

listener.Start(); // Start the listener to begin collecting data

this._multiMessageHandlerStub.ResponsesToReturn.Add(
Expand All @@ -90,12 +100,16 @@ public async Task FunctionUsageMetricsAreCapturedByTelemetryAsExpected()

var kernelFunction = KernelFunctionFactory.CreateFromPrompt("prompt", loggerFactory: this._mockLoggerFactory.Object);

// Act
// Act & Assert
var result = await kernel.InvokeAsync(kernelFunction);

// Assert
Assert.Contains(12, measurements["semantic_kernel.function.invocation.token_usage.prompt"]);
Assert.Contains(5, measurements["semantic_kernel.function.invocation.token_usage.completion"]);
listener.Dispose();

while (!completed)
{
// Wait for the measurements to be completed
await Task.Delay(100);
}
}

public void Dispose()
Expand Down
22 changes: 18 additions & 4 deletions dotnet/src/Connectors/Connectors.OpenAI.UnitTests/KernelCore/KernelTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,16 @@ public async Task FunctionUsageMetricsAreCapturedByTelemetryAsExpected()
}
});

var completed = false;

listener.MeasurementsCompleted = (instrument, state) =>
{
completed = true;
// Stop the listener to stop collecting data
Assert.Contains(12, measurements["semantic_kernel.function.invocation.token_usage.prompt"]);
Assert.Contains(5, measurements["semantic_kernel.function.invocation.token_usage.completion"]);
};

listener.Start(); // Start the listener to begin collecting data

this._multiMessageHandlerStub.ResponsesToReturn.Add(
Expand All @@ -91,12 +101,16 @@ public async Task FunctionUsageMetricsAreCapturedByTelemetryAsExpected()

var kernelFunction = KernelFunctionFactory.CreateFromPrompt("prompt", loggerFactory: this._mockLoggerFactory.Object);

// Act
// Act & Assert
var result = await kernel.InvokeAsync(kernelFunction);

// Assert
Assert.Contains(12, measurements["semantic_kernel.function.invocation.token_usage.prompt"]);
Assert.Contains(5, measurements["semantic_kernel.function.invocation.token_usage.completion"]);
listener.Dispose();

while (!completed)
{
// Wait for the measurements to be completed
await Task.Delay(100);
}
Comment thread
rogerbarreto marked this conversation as resolved.
}

public void Dispose()
Expand Down
Loading