Add typing indicator animation#419
Merged
adrianwyatt merged 11 commits intomicrosoft:mainfrom Apr 12, 2023
Merged
Conversation
Vivihung
added
PR: ready for review
shawncal
added
PR: feedback to address
SergeyMenshykh
previously approved these changes
Apr 12, 2023
Vivihung
added
PR: ready for review
adrianwyatt
approved these changes
Apr 12, 2023
dehoward
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
### Motivation and Context Today, the app did nothing after a user submitted a chat. The user doesn't know if the app is working or not. Therefore, we need a visual animation when the bot prepares a response. It could improve the user experience on the perceptional response time. ### Description - Leverage the latest Fluent UI Animation component to render the loading balls animation with frames. - Checkin the loading balls frames as an SVG - Add TypeScript support in importing SVG
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
### Motivation and Context Today, the app did nothing after a user submitted a chat. The user doesn't know if the app is working or not. Therefore, we need a visual animation when the bot prepares a response. It could improve the user experience on the perceptional response time. ### Description - Leverage the latest Fluent UI Animation component to render the loading balls animation with frames. - Checkin the loading balls frames as an SVG - Add TypeScript support in importing SVG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Today, the app did nothing after a user submitted a chat. The user doesn't know if the app is working or not. Therefore, we need a visual animation when the bot prepares a response. It could improve the user experience on the perceptional response time.
Description
Contribution Checklist
The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified withdotnet formatAll unit tests pass, and I have added new tests where possible