Use String interpolation in SQLiteConnection data source name#431
Closed
kbeaugrand wants to merge 5 commits intomicrosoft:mainfrom
Closed
Use String interpolation in SQLiteConnection data source name#431kbeaugrand wants to merge 5 commits intomicrosoft:mainfrom
kbeaugrand wants to merge 5 commits intomicrosoft:mainfrom
Conversation
kbeaugrand
changed the title
adrianwyatt
previously approved these changes
Apr 13, 2023
adrianwyatt
added
PR: ready to merge
Contributor
|
@adrianwyatt this issue will be resolved by #425 |
auto-merge was automatically disabled
April 13, 2023 05:19
Head branch was pushed to by a user without write access
adrianwyatt
previously approved these changes
Apr 13, 2023
Contributor
|
Dupe with #425 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fix #430
SQLite database is not created with the expected name.
Instead of the expected file name, we get a file name "{filename}" created in the current directory.
This issue occurs because the argumement is not passed correctly to the format function.
Description
The change only modify the SQLiteConnection instance by using the good string interpolation with the argument.
Contribution Checklist
dotnet format