.Net: Markdown prompt support (without tool call support)#5961
Merged
markwallace-microsoft merged 39 commits intomicrosoft:feature-promptyfrom Apr 29, 2024
Merged
Conversation
markwallace-microsoft
added
.NET
github-actions
Bot
changed the title
LittleLittleCloud
changed the title
stephentoub
reviewed
Apr 22, 2024
stephentoub
reviewed
Apr 22, 2024
LittleLittleCloud
force-pushed
the
u/xiaoyun/prompty
branch
from
e074b97 to
da663ad
Compare
LittleLittleCloud
changed the title
stephentoub
reviewed
Apr 25, 2024
| public string? AzureDeployment { get; set; } | ||
|
|
||
| [YamlMember(Alias = "api_key")] | ||
| public string? ApiKey { get; set; } |
Member
There was a problem hiding this comment.
Is this information really put into a prompty file?
Contributor
There was a problem hiding this comment.
This information would tie a Prompty file to one particular deployment. These will change frequently as new models emerge and these artifacts should be easily transferable to other contexts e.g. a Prompty file the Data Scientists developed should be transferable to another team to deploy. Or if I'm building a product my Prompty files should run with any customer deployment.
In our YAML file we include the model configuration i.e. temperature, top_p, ... but not the model deployment, that is treated as a seperate concern.
…ate.cs Co-authored-by: Stephen Toub <stoub@microsoft.com>
…ate.cs Co-authored-by: Stephen Toub <stoub@microsoft.com>
…ate.cs Co-authored-by: Stephen Toub <stoub@microsoft.com>
…ate.cs Co-authored-by: Stephen Toub <stoub@microsoft.com>
…lExtension.cs Co-authored-by: Stephen Toub <stoub@microsoft.com>
Co-authored-by: Stephen Toub <stoub@microsoft.com>
Co-authored-by: Stephen Toub <stoub@microsoft.com>
…lExtension.cs Co-authored-by: Stephen Toub <stoub@microsoft.com>
This was referenced Apr 29, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Description
This PR brings markdown prompt template support for semantic kernel. It essentially does a code-level copy of the original markdown prompt template implementation to the sk repo, plus an extension API to execute the template.
Because the markdown prompt template support is still in an very, very early stage. All code is put underExperimentalnamespace and all the class except the extension API is marked as internal only.You can find the spec for the markdown prompt template here
The intergration comes with two projects
ChatPromptParserKernelFunctionFromPromptfrom prompty file viaCreateFunctionFromPromptyAPIThe tool call support will come in the next PR as this PR is already growing large. Also tool call support needs some extra care which might need further discussion on how to implement cohere to sk pattern
Contribution Checklist