Skip to content

Add 'SaveAsync' Function to TextMemorySkill#6

Merged
dluc merged 6 commits intomicrosoft:mainfrom
awharrison-28:add_save_function_to_textmemoryskill
Mar 1, 2023
Merged

Add 'SaveAsync' Function to TextMemorySkill#6
dluc merged 6 commits intomicrosoft:mainfrom
awharrison-28:add_save_function_to_textmemoryskill

Conversation

@awharrison-28
Copy link
Copy Markdown
Contributor

@awharrison-28 awharrison-28 commented Mar 1, 2023

Motivation and Context

Currently, semantic memory can only be added to directly through the kernel. Users should be able to save information to semantic memory using TextMemorySkill.

Description

Added the semantic function SaveAsync to TextMemorySkill.

Additionally updated Example15_MemorySkill to demonstrate how to use the new functionality. I manually verified that the example output remains unchanged.

Contribution Checklist

@awharrison-28 awharrison-28 added the PR: ready for review All feedback addressed, ready for reviews label Mar 1, 2023
@awharrison-28 awharrison-28 requested a review from shawncal March 1, 2023 01:19
Comment thread dotnet/src/SemanticKernel/CoreSkills/TextMemorySkill.cs Outdated
Comment thread dotnet/src/SemanticKernel/CoreSkills/TextMemorySkill.cs Outdated
Comment thread dotnet/src/SemanticKernel/CoreSkills/TextMemorySkill.cs Outdated
Comment thread samples/dotnet/kernel-syntax-examples/Example15_MemorySkill.cs Outdated
Comment thread samples/dotnet/kernel-syntax-examples/Example15_MemorySkill.cs Outdated
Comment thread dotnet/src/SemanticKernel/CoreSkills/TextMemorySkill.cs Outdated
…ext parameter -> context variable; added 'save' to skill capabilities description
@dluc dluc merged commit ec24e72 into microsoft:main Mar 1, 2023
@dluc dluc deleted the add_save_function_to_textmemoryskill branch March 1, 2023 02:30
adrianwyatt added a commit that referenced this pull request Apr 3, 2023
Build and style fixes in OpenAPI skill (#297)
@cherchyk cherchyk mentioned this pull request Jun 21, 2023
alliscode pushed a commit that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: ready for review All feedback addressed, ready for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants