Skip to content

.Net Fix - Include role definition for each StreamingChatMessageContent #6957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crickman merged 5 commits into from
Jun 25, 2024
Merged

.Net Fix - Include role definition for each StreamingChatMessageContent #6957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b18b55b
Fixed
crickman Jun 25, 2024
34ca63e
Formatting
crickman Jun 25, 2024
0282c72
Final format
crickman Jun 25, 2024
93fab9e
Merge branch 'main' into fix_streaming_message_role
crickman Jun 25, 2024
149b899
Merge branch 'main' into fix_streaming_message_role
crickman Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion dotnet/src/Connectors/Connectors.OpenAI/AzureSdk/ClientCore.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,7 +693,18 @@ internal async IAsyncEnumerable<OpenAIStreamingChatMessageContent> GetStreamingC
OpenAIFunctionToolCall.TrackStreamingToolingUpdate(update.ToolCallUpdate, ref toolCallIdsByIndex, ref functionNamesByIndex, ref functionArgumentBuildersByIndex);
}

var openAIStreamingChatMessageContent = new OpenAIStreamingChatMessageContent(update, update.ChoiceIndex ?? 0, this.DeploymentOrModelName, metadata) { AuthorName = streamedName };
AuthorRole? role = null;
if (streamedRole.HasValue)
{
role = new AuthorRole(streamedRole.Value.ToString());
}

OpenAIStreamingChatMessageContent openAIStreamingChatMessageContent =
new(update, update.ChoiceIndex ?? 0, this.DeploymentOrModelName, metadata)
{
AuthorName = streamedName,
Role = role,
Comment thread
dmytrostruk marked this conversation as resolved.
};
Comment thread
crickman marked this conversation as resolved.

if (update.ToolCallUpdate is StreamingFunctionToolCallUpdate functionCallUpdate)
{
Expand Down
5 changes: 5 additions & 0 deletions dotnet/src/IntegrationTests/Connectors/OpenAI/OpenAICompletionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,11 @@ public async Task AzureOpenAIStreamingTestAsync(bool useChatModel, string prompt
// Act
await foreach (var content in target.InvokeStreamingAsync<StreamingKernelContent>(plugins["ChatPlugin"]["Chat"], new() { [InputParameterName] = prompt }))
{
if (content is StreamingChatMessageContent messageContent)
{
Assert.NotNull(messageContent.Role);
}

fullResult.Append(content);
}

Expand Down