Python: Verify local models in Ollama and LM Studio are compatible with the OpenAI connector#6973
Merged
TaoChenOSU merged 15 commits intomicrosoft:mainfrom Jul 5, 2024
Conversation
markwallace-microsoft
added
the
python
github-actions
Bot
changed the title
Contributor
Python 3.10 Test Coverage Report •
Python 3.10 Unit Test Overview
|
||||||||||||||||||||||||||||||
alliscode
approved these changes
Jun 26, 2024
Member
eavanvalkenburg
left a comment
eavanvalkenburg
left a comment
There was a problem hiding this comment.
small note, let's make it so that you can just use the Completion service directly instead of having to create your own client!
moonbox3
reviewed
Jun 27, 2024
alliscode
approved these changes
Jun 28, 2024
AndreasKunar
suggested changes
Jul 2, 2024
AndreasKunar
left a comment
AndreasKunar
left a comment
There was a problem hiding this comment.
Still fails for me because of the missing API-key parameter in line 39 (see comment for details on the validation error).
moonbox3
approved these changes
Jul 5, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
moonbox3
approved these changes
Jul 5, 2024
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
…th the OpenAI connector (microsoft#6973) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Related to microsoft#6498 The use of local models presents a twofold benefit for developers: increased flexibility and reduced costs. Ollama and LM Studio are two well-known platforms that facilitate the hosting of models locally, both of which offer compatibility with OpenAI endpoints. As such, it is imperative that our OpenAI connector functions correctly when users are operating models on these platforms. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> 1. Verify that our OpenAI connector works as expected with models hosted locally using Ollama and LM Studio. 2. Create three new samples (Ollama/chat, LM Studio/chat, LM Studio/Embedding) under `/concepts/local_models` to show how to using local models with the OpenAI connector. 3. Fix a bug in `test_sample_utils.py` where if a test case is retried and input was never reset. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Related to #6498
The use of local models presents a twofold benefit for developers: increased flexibility and reduced costs. Ollama and LM Studio are two well-known platforms that facilitate the hosting of models locally, both of which offer compatibility with OpenAI endpoints. As such, it is imperative that our OpenAI connector functions correctly when users are operating models on these platforms.
Description
/concepts/local_modelsto show how to using local models with the OpenAI connector.test_sample_utils.pywhere if a test case is retried and input was never reset.Contribution Checklist