Skip to content

.Net: Decode unicode escapes in TextMemoryPlugin recall#7052

Closed
atiq-bs23 wants to merge 2 commits intomicrosoft:mainfrom
atiq-bs23:text-memory-plugin-enhancement
Closed

.Net: Decode unicode escapes in TextMemoryPlugin recall#7052
atiq-bs23 wants to merge 2 commits intomicrosoft:mainfrom
atiq-bs23:text-memory-plugin-enhancement

Conversation

@atiq-bs23
Copy link
Copy Markdown
Contributor

Motivation and Context

TextMemoryPlugin RecallAsync returns encoded data if the data is not English.

Description

I have added a method to decode unicode escape sequences.

Contribution Checklist

@atiq-bs23 atiq-bs23 requested a review from a team as a code owner July 2, 2024 13:06
@markwallace-microsoft markwallace-microsoft added the .NET Issue or Pull requests regarding .NET code label Jul 2, 2024
@github-actions github-actions Bot changed the title Decode unicode escapes in TextMemoryPlugin recall .Net: Decode unicode escapes in TextMemoryPlugin recall Jul 2, 2024
@atiq-bs23
Copy link
Copy Markdown
Contributor Author

#6593 issue is related

@westey-m
Copy link
Copy Markdown
Contributor

westey-m commented Jul 4, 2024

Closing this PR, since this change could be a breaking change for some customers, but I've created a new PR that allows customizing the JsonSerializer behavior to output unescaped characters to begin with.
See #7098

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

.NET Issue or Pull requests regarding .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants