Python: allow more options for FunctionCallContent constructor#7105
Merged
eavanvalkenburg merged 11 commits intomicrosoft:mainfrom Jul 11, 2024
Merged
Python: allow more options for FunctionCallContent constructor#7105eavanvalkenburg merged 11 commits intomicrosoft:mainfrom
eavanvalkenburg merged 11 commits intomicrosoft:mainfrom
Conversation
markwallace-microsoft
added
the
python
Contributor
Python 3.10 Test Coverage Report •
Python 3.10 Unit Test Overview
|
moonbox3
approved these changes
Jul 5, 2024
glahaye
approved these changes
Jul 5, 2024
eavanvalkenburg
force-pushed
the
fix_6932
branch
from
930adf0 to
6882ccf
Compare
eavanvalkenburg
force-pushed
the
fix_6932
branch
from
302721f to
efc7a58
Compare
moonbox3
approved these changes
Jul 10, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
eavanvalkenburg
force-pushed
the
fix_6932
branch
from
ae584e2 to
3158286
Compare
eavanvalkenburg
force-pushed
the
fix_6932
branch
from
3158286 to
0092f38
Compare
moonbox3
approved these changes
Jul 10, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
moonbox3
approved these changes
Jul 10, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
eavanvalkenburg
force-pushed
the
fix_6932
branch
from
745c95d to
4993722
Compare
moonbox3
approved these changes
Jul 11, 2024
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
…soft#7105) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Fix microsoft#6932 Added ability to supply function_name and plugin_name as well as name (name keeps precedence) Added ability to supply arguments as a dict, instead of string. Also ups the test coverage for the contents folder. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fix #6932
Added ability to supply function_name and plugin_name as well as name (name keeps precedence)
Added ability to supply arguments as a dict, instead of string.
Also ups the test coverage for the contents folder.
Description
Contribution Checklist