Python: Introduce the single, non-group chat completion agent#7116
Merged
moonbox3 merged 22 commits intomicrosoft:mainfrom Jul 11, 2024
Merged
Python: Introduce the single, non-group chat completion agent#7116moonbox3 merged 22 commits intomicrosoft:mainfrom
moonbox3 merged 22 commits intomicrosoft:mainfrom
Conversation
markwallace-microsoft
added
python
Contributor
Python 3.10 Test Coverage Report •
Python 3.10 Unit Test Overview
|
crickman
approved these changes
Jul 5, 2024
Contributor
crickman
left a comment
crickman
left a comment
There was a problem hiding this comment.
Great parity! If there's any detail you'd like me to zoom-into, please feel free to direct my attention.
TaoChenOSU
reviewed
Jul 5, 2024
Member
eavanvalkenburg
left a comment
eavanvalkenburg
left a comment
There was a problem hiding this comment.
lots of small comments!
TaoChenOSU
reviewed
Jul 10, 2024
TaoChenOSU
approved these changes
Jul 10, 2024
Member
eavanvalkenburg
left a comment
eavanvalkenburg
left a comment
There was a problem hiding this comment.
I think we can make it simpler taking advantage of Python!
TaoChenOSU
approved these changes
Jul 11, 2024
crickman
suggested changes
Jul 11, 2024
eavanvalkenburg
approved these changes
Jul 11, 2024
Member
eavanvalkenburg
left a comment
eavanvalkenburg
left a comment
There was a problem hiding this comment.
Couple of small nits, but looking good overall!
crickman
approved these changes
Jul 11, 2024
crickman
approved these changes
Jul 11, 2024
eavanvalkenburg
approved these changes
Jul 11, 2024
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
…oft#7116) ### Motivation and Context Following in the steps of dotnet, we're beginning to add agent support to Python. For an initial implementation the focus is on non-grouped, chat completion agents. The first pass is covering a ChatCompletionAgent that allows the user to define a ChatCompletion Service as part of the SK Kernel, and then reference that service in an agent implementation. <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description The PR: - Adds support for a standard chat completion agent - Adds the required abstractions to allow the single chat completion agent to work - Introduces a new agent concept sample showing how to invoke the agent for a streaming and non-streaming context. - Adds unit tests to cover the new code - Closes microsoft#7079  <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Following in the steps of dotnet, we're beginning to add agent support to Python. For an initial implementation the focus is on non-grouped, chat completion agents. The first pass is covering a ChatCompletionAgent that allows the user to define a ChatCompletion Service as part of the SK Kernel, and then reference that service in an agent implementation.
Description
The PR:
Contribution Checklist