This repository was archived by the owner on Jul 18, 2024. It is now read-only.
Improved performance. Added SourcesContent support #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
christiango
reviewed
Feb 21, 2018
|
|
||
| namespace SourcemapToolkit.SourcemapParser | ||
| { | ||
| using System.Text; |
Member
There was a problem hiding this comment.
Can you move this to be next to the other using statement in this file instead of inside the namespace?
|
|
||
| namespace SourcemapToolkit.SourcemapParser | ||
| { | ||
| using System.Linq; |
Member
There was a problem hiding this comment.
Same thing about putting the imports next to the other imports in this file instead of inside the namespace
| Version = sourceMap.Version, | ||
| Mappings = sourceMap.Mappings, | ||
| Sources = sourceMap.Sources == null ? null : new List<string>(sourceMap.Sources), | ||
| SourcesContent = sourceMap.SourcesContent == null ? null : new List<string>(sourceMap.SourcesContent), |
Member
There was a problem hiding this comment.
Can you add a simple test to cover the sources content population?
Contributor
Author
|
@christiango Check again, please |
christiango
approved these changes
Feb 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.