Skip to content

Conversation

@corinagum
Copy link
Collaborator

@corinagum corinagum commented Jan 27, 2024

Linked issues

fixes: #1154, #1182, #1157,

Details

Fix bugs to TeamsAttachmentDownloader

  • No longer hardcoded to use public Azure cloud (getAccessToken now allows for varying credential types & clouds)
  • Allow localhost attachments
  • Only create request header for attachments when bot credentials are enabled
  • Update Card Gazer sample to send error messages for design use

Attestation Checklist

  • My code follows the style guidelines of this project

  • I have checked for/fixed spelling, linting, and other errors

  • I have commented my code for clarity

  • I have made corresponding changes to the documentation (updating the doc strings in the code is sufficient)

  • My changes generate no new warnings

  • I have added tests that validates my changes, and provides sufficient test coverage. I have tested with:

    • Local testing
    • E2E testing in Teams
  • New and existing unit tests pass locally with my changes

Additional information

Feel free to add other relevant information below

@corinagum corinagum changed the title [DRAFT][JS] fix: #1154, #1182, and #1157: TeamsAttachmentDownloader updates [JS] fix: #1154, #1182, and #1157: TeamsAttachmentDownloader updates Jan 29, 2024
@corinagum corinagum marked this pull request as ready for review January 30, 2024 17:28
@corinagum corinagum requested review from a team, aacebo, lilyydu and singhk97 as code owners January 30, 2024 17:28
@corinagum corinagum force-pushed the cg/teams-attch-dler branch from 5850040 to 17ff4f1 Compare January 30, 2024 18:13
Copy link
Collaborator

@singhk97 singhk97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .vscode and env folders should also be moved to the cardGazer folder. They are both needed for the F5 debug flow. It's possible that the F5 flow will trip if the env folder (and the env.local file) is missing.

aacebo
aacebo previously approved these changes Jan 31, 2024
@corinagum corinagum merged commit 76d6b29 into main Jan 31, 2024
@corinagum corinagum deleted the cg/teams-attch-dler branch January 31, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: TeamsAttachmentDownloader doesn't work in Bot Framework Emulator

4 participants