-
Notifications
You must be signed in to change notification settings - Fork 293
Introduce interpolated string handler overloads for assertions #4476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Evangelink
merged 46 commits into
microsoft:main
from
Youssef1313:interpolated-string-handler
Jan 3, 2025
Merged
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
35f2d07
Add interpolated string handler overloads for Assert.IsTrue/IsFalse
Youssef1313 13d599f
Add interpolated string handler overloads for Assert.IsNull/IsNotNull
Youssef1313 7cbafc1
Refactor
Youssef1313 94084b1
Assert.AreEqual/AreNotEqual [WIP]
Youssef1313 4c21c0b
Refactor
Youssef1313 5f92199
AreEqual progress [WIP]
Youssef1313 9eb9615
Progress [WIP]
Youssef1313 d020353
Better progress for AreEqual
Youssef1313 8dffd67
Suppress FPs
Youssef1313 ebd0bc5
PublicAPI
Youssef1313 7c903d2
PublicAPI
Youssef1313 90a460a
Fix conditionals
Youssef1313 bbce272
PublicAPI
Youssef1313 aaa98bb
Progress for IsInstanceOfType/IsNotInstanceOfType
Youssef1313 8e437e3
AreSame/AreNotSame progress
Youssef1313 3ed20e8
Fix formatting
Youssef1313 41392d3
Better coverage for IsTrue/IsFalse
Youssef1313 60cd5ad
Better coverage
Youssef1313 56a258d
Refactor Assert.Throws in preparation for interpolated string handler…
Youssef1313 15731f0
Progress for Assert.Throws/ThrowsExactly
Youssef1313 715bb30
Fix missing assignment to _state
Youssef1313 409afc1
Test coverage for AreSame/AreNotSame
Youssef1313 9f7780e
Reference Roslyn issue link
Youssef1313 271a7ef
More AreSame tests
Youssef1313 4b9c798
More prgoress
Youssef1313 cecdbc5
Missing changes for IsInstanceOf
Youssef1313 f6753aa
Little more coverage for IsInstanceOfType
Youssef1313 5fe77b1
Fix test
Youssef1313 32d15fc
Fix test
Youssef1313 12a011c
Avoid extra ToString
Youssef1313 38f6c91
Revert temporarily, will apply globally once it's more understood
Youssef1313 7795c53
Remove redundant readonly
Youssef1313 cb56d77
More AppendFormatted overloads, modulo tests
Youssef1313 bffbd63
Use AppendFormat
Youssef1313 15c42ed
Fix build
Youssef1313 8ec485d
Address TODO
Youssef1313 abcf014
Fix build
Youssef1313 6723745
Fix build
Youssef1313 99d3e8b
More progress
Youssef1313 df8264d
AppendFormatted
Youssef1313 56fa24c
Remove unused using
Youssef1313 cf1c868
More test coverage
Youssef1313 f51cb70
Renames
Youssef1313 b8738a3
Renames
Youssef1313 344196c
Small fix
Youssef1313 1c137de
Add AppendFormatted string overload
Youssef1313 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
715 changes: 589 additions & 126 deletions
715
src/TestFramework/TestFramework/Assertions/Assert.AreEqual.cs
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.