Skip to content

Use different message for Assert.AreEqual when string difference is casing only #4525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Evangelink merged 1 commit into from
Jan 6, 2025
Merged

Use different message for Assert.AreEqual when string difference is casing only #4525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/TestFramework/TestFramework/Assertions/Assert.AreEqual.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,7 +698,8 @@ private static void ThrowAssertAreEqualFailed<T>(T expected, T actual, T delta,
[DoesNotReturn]
private static void ThrowAssertAreEqualFailed(string? expected, string? actual, bool ignoreCase, CultureInfo culture, string userMessage)
{
string finalMessage = !ignoreCase && CompareInternal(expected, actual, ignoreCase, culture) == 0
// If the user requested to match case, and the difference between expected/actual is casing only, then we use a different message.
string finalMessage = !ignoreCase && CompareInternal(expected, actual, ignoreCase: true, culture) == 0
? string.Format(
CultureInfo.CurrentCulture,
FrameworkMessages.AreEqualCaseFailMsg,
Expand Down
3 changes: 2 additions & 1 deletion test/UnitTests/TestFramework.UnitTests/Assertions/AssertTests.AreEqualTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,8 @@ public void AreEqual_WithEnglishCultureAndDoesNotIgnoreCase_Throws()
var englishCulture = new CultureInfo("en-EN");

// Won't ignore case.
VerifyThrows(() => Assert.AreEqual(expected, actual, false, englishCulture));
Exception ex = VerifyThrows(() => Assert.AreEqual(expected, actual, false, englishCulture));
Verify(ex.Message == "Assert.AreEqual failed. Expected:<i>. Case is different for actual value:<I>. ");
}

public void AreEqual_WithTurkishCultureAndDoesNotIgnoreCase_Throws()
Expand Down