Unify reflection helpers by Evangelink · Pull Request #7344 · microsoft/testfx

Evangelink · 2026-02-04T16:02:44Z

# Conflicts: # src/Adapter/MSTestAdapter.PlatformServices/Services/ReflectionOperations.cs # test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Execution/TestPropertyAttributeTests.cs # test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Execution/TypeCacheTests.cs # test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Helpers/ReflectHelperTests.cs

…tion # Conflicts: # src/Adapter/MSTestAdapter.PlatformServices/Services/ReflectionOperations.cs # src/Adapter/MSTestAdapter.PlatformServices/Services/TestDeployment.cs # src/Adapter/MSTestAdapter.PlatformServices/Utilities/DeploymentItemUtility.cs # src/Adapter/MSTestAdapter.PlatformServices/Utilities/DeploymentUtilityBase.cs # src/Adapter/MSTestAdapter.PlatformServices/Utilities/ReflectionOperationsNetFrameworkAttributeHelpers.cs # test/IntegrationTests/PlatformServices.Desktop.IntegrationTests/ReflectionUtilityTests.cs # test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Services/DesktopTestDeploymentTests.cs # test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Services/TestDeploymentTests.cs # test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Utilities/DeploymentItemUtilityTests.cs # test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Utilities/DeploymentUtilityTests.cs # test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Utilities/ReflectionUtilityTests.cs

Youssef1313

I guess we are good now that everything uses the caching ReflectHelper on current main?

(Except that we need to investigate if it's possible to simplify the implementation of reflection operations under .NET Framework)

Evangelink · 2026-04-17T18:33:41Z

@copilot resolve the merge conflicts in this pull request

…tion # Conflicts: # src/Adapter/MSTestAdapter.PlatformServices/Discovery/AssemblyEnumerator.cs # src/Adapter/MSTestAdapter.PlatformServices/Discovery/TypeEnumerator.cs # src/Adapter/MSTestAdapter.PlatformServices/Execution/TypeCache.cs # src/Adapter/MSTestAdapter.PlatformServices/Helpers/ReflectHelper.cs # test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Discovery/TestMethodValidatorTests.cs # test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Discovery/TypeEnumeratorTests.cs # test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Execution/TypeCacheTests.cs # test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Execution/UnitTestRunnerTests.cs Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

Copilot · 2026-04-17T18:40:59Z

@copilot resolve the merge conflicts in this pull request

Resolved the merge conflicts and pushed the merge commit: 19c164645.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

k4kvsblobprodcus344.vsblob.vsassets.io
- Triggering command: /home/REDACTED/work/testfx/testfx/.dotnet/dotnet /home/REDACTED/work/testfx/testfx/.dotnet/dotnet msbuild /m /nologo /clp:Summary /v:minimal /nr:true /warnaserror /p:TreatWarningsAsErrors=true /p:ContinuousIntegrationBuild=false /home/REDACTED/work/testfx/testfx/artifacts/toolset/restore.proj /t:__WriteToolsetLocation /clp:ErrorsOnly;NoSummary /p:__ToolsetLocationOutputFile=/home/REDACTED/work/testfx/testfx/artifacts/toolset/11.0.0-beta.26211.1.txt (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Evangelink · 2026-04-21T07:49:32Z

@copilot fix the following issues:

@azure-pipelines
azure-pipelines
/ microsoft.testfx (Build Linux Debug)
src/Adapter/MSTestAdapter.PlatformServices/Execution/UnitTestRunner.cs#L68

src/Adapter/MSTestAdapter.PlatformServices/Execution/UnitTestRunner.cs(68,36): error CS1503: (NETCORE_ENGINEERING_TELEMETRY=Build) Argument 1: cannot convert from 'Microsoft.VisualStudio.TestPlatform.MSTestAdapter.PlatformServices.Interface.IReflectionOperations' to 'Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.Helpers.ReflectHelper'
Check failure on line 146 in src/Adapter/MSTestAdapter.PlatformServices/Discovery/AssemblyEnumerator.cs

@azure-pipelines
azure-pipelines
/ microsoft.testfx (Build Linux Debug)
src/Adapter/MSTestAdapter.PlatformServices/Discovery/AssemblyEnumerator.cs#L146

src/Adapter/MSTestAdapter.PlatformServices/Discovery/AssemblyEnumerator.cs(146,47): error CS1503: (NETCORE_ENGINEERING_TELEMETRY=Build) Argument 1: cannot convert from 'Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.Helpers.ReflectHelper' to 'Microsoft.VisualStudio.TestPlatform.MSTestAdapter.PlatformServices.Interface.IReflectionOperations'

Agent-Logs-Url: https://github.com/microsoft/testfx/sessions/9871953f-0d75-4a8e-85db-642a7fb4732d Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

Copilot · 2026-04-21T08:03:08Z

@copilot fix the following issues:

@azure-pipelines
...

Fixed and pushed in f6aa41d.

I aligned the affected reflection-related files to consistent types, which resolves the CS1503 constructor/signature mismatches and related compile errors.

UI screenshot: N/A (no UI changes in this PR).

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

c50vsblobprodcus330.vsblob.vsassets.io
- Triggering command: /home/REDACTED/work/testfx/testfx/.dotnet/dotnet /home/REDACTED/work/testfx/testfx/.dotnet/dotnet msbuild /m /nologo /clp:Summary /v:minimal /nr:true /warnaserror /p:TreatWarningsAsErrors=true /p:ContinuousIntegrationBuild=false /home/REDACTED/.nuget/packages/microsoft.dotnet.arcade.sdk/11.0.0-beta.26211.1/tools/Build.proj /p:Configuration=Debug /p:RepoRoot=/home/REDACTED/work/testfx/testfx/ /p:Restore=true /p:Build=true /p:DotNetBuild=false /p:DotNetBuildSourceOnly=false /p:DotNetBuildFromVMR=false /p:Rebuild=false /p:Test=true (dns block)
jd4vsblobprodcus366.vsblob.vsassets.io
- Triggering command: /home/REDACTED/work/testfx/testfx/.dotnet/dotnet /home/REDACTED/work/testfx/testfx/.dotnet/dotnet msbuild /m /nologo /clp:Summary /v:minimal /nr:true /warnaserror /p:TreatWarningsAsErrors=true /p:ContinuousIntegrationBuild=false /home/REDACTED/.nuget/packages/microsoft.dotnet.arcade.sdk/11.0.0-beta.26211.1/tools/Build.proj /p:Configuration=Debug /p:RepoRoot=/home/REDACTED/work/testfx/testfx/ /p:Restore=true /p:Build=true /p:DotNetBuild=false /p:DotNetBuildSourceOnly=false /p:DotNetBuildFromVMR=false /p:Rebuild=false /p:Test=true (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Unify reflection helpers

bce4b9c

Evangelink marked this pull request as ready for review February 6, 2026 13:39

Evangelink enabled auto-merge February 6, 2026 13:39

Youssef1313 reviewed Feb 6, 2026

View reviewed changes

Comment thread src/Adapter/MSTestAdapter.PlatformServices/Services/ReflectionOperations.cs Outdated

Evangelink added 9 commits February 6, 2026 17:03

Simplify further

3a29b63

Apply Youssef changes

ed70197

More updates

2ca249e

Massive refactoring

c437564

Fix glitches

5568ca8

Fixes

23e4303

Even more

875ae8d

Again

68b754d

Youssef1313 mentioned this pull request Feb 8, 2026

First step removing ReflectionUtility #7361

Merged

Evangelink added 3 commits February 9, 2026 14:10

Merge branch 'main' into dev/amauryleve/reflection

fb58d01

more

d57fedf

Youssef1313 reviewed Feb 10, 2026

View reviewed changes

Comment thread src/Adapter/MSTestAdapter.PlatformServices/Services/ReflectionOperations.cs

This was referenced Apr 3, 2026

[repo-status] Daily Repo Status — April 3, 2026 #7671

Closed

[repo-status] Daily Repo Status – April 6, 2026 #7681

Closed

Copilot started work on behalf of Evangelink April 17, 2026 18:33 View session

Copilot AI review requested due to automatic review settings April 17, 2026 18:40

Evangelink review requested due to automatic review settings April 17, 2026 18:40

Copilot finished work on behalf of Evangelink April 17, 2026 18:41

Copilot started work on behalf of Evangelink April 21, 2026 07:49 View session

Fix reflection helper type mismatches causing CI build failures

f6aa41d

Agent-Logs-Url: https://github.com/microsoft/testfx/sessions/9871953f-0d75-4a8e-85db-642a7fb4732d Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

Copilot AI review requested due to automatic review settings April 21, 2026 08:02

Evangelink review requested due to automatic review settings April 21, 2026 08:02

Copilot stopped work on behalf of Evangelink due to an error April 21, 2026 08:04
The "Build the repository" custom setup step from your .github/workflows/copilot-setup-steps.yml file failed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unify reflection helpers#7344

Unify reflection helpers#7344
Evangelink wants to merge 15 commits intomainfrom
dev/amauryleve/reflection

Evangelink commented Feb 4, 2026 •

edited

Loading

Uh oh!

Uh oh!

Youssef1313 left a comment

Uh oh!

Uh oh!

Evangelink commented Apr 17, 2026

Uh oh!

Copilot AI commented Apr 17, 2026 •

edited

Loading

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Evangelink commented Apr 21, 2026

Uh oh!

Copilot AI commented Apr 21, 2026 •

edited

Loading

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Evangelink commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Youssef1313 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Evangelink commented Apr 17, 2026

Uh oh!

Copilot AI commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Evangelink commented Apr 21, 2026

Uh oh!

Copilot AI commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Evangelink commented Feb 4, 2026 •

edited

Loading

Copilot AI commented Apr 17, 2026 •

edited

Loading

Copilot AI commented Apr 21, 2026 •

edited

Loading