Skip to content

Open up orchestrator experimentally#7409

Merged
Evangelink merged 14 commits intomainfrom
dev/amauryleve/orchestrator
Mar 6, 2026
Merged

Open up orchestrator experimentally#7409
Evangelink merged 14 commits intomainfrom
dev/amauryleve/orchestrator

Conversation

@Evangelink
Copy link
Copy Markdown
Member

Fix #5554

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR exposes the test host orchestrator functionality as a public experimental API to enable third-party extensions to implement custom orchestration strategies (e.g., distributing tests across processes/machines or implementing custom retry logic).

Changes:

  • Made ITestHostOrchestrator and ITestHostOrchestratorManager public interfaces with experimental attribute
  • Created IInternalTestHostOrchestratorManager to retain internal-only members while exposing core functionality publicly
  • Added TestHostOrchestrator property to ITestApplicationBuilder as an experimental public API
  • Simplified RetryExtensions to use the new public API instead of casting to internal types

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
ITestHostOrchestrator.cs Made interface public and added XML documentation and experimental attribute
ITestHostOrchestratorManager.cs Split into public interface with experimental attribute and internal interface for advanced functionality
TestHostOrchestratorManager.cs Updated to implement the internal interface
ITestHostBuilder.cs Updated to use internal interface type
TestHostBuilder.cs Updated to use internal interface type
ITestApplicationBuilder.cs Added public experimental property for TestHostOrchestrator
TestApplicationBuilder.cs Implemented public experimental property for TestHostOrchestrator
PublicAPI.Unshipped.txt Added public API entries for new orchestrator interfaces and property
RetryExtensions.cs Simplified to use public API instead of internal casting

Comment thread src/Platform/Microsoft.Testing.Extensions.Retry/RetryExtensions.cs
Comment thread src/Platform/Microsoft.Testing.Platform/Hosts/TestHostBuilder.cs Outdated
Comment thread src/Platform/Microsoft.Testing.Platform/PublicAPI/PublicAPI.Unshipped.txt Outdated
Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
Copilot AI review requested due to automatic review settings February 20, 2026 11:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 31 out of 31 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings March 5, 2026 14:37
@Evangelink Evangelink enabled auto-merge March 5, 2026 14:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 34 out of 34 changed files in this pull request and generated 2 comments.

Copilot AI review requested due to automatic review settings March 6, 2026 10:04
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 33 out of 33 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (2)

test/UnitTests/Microsoft.Testing.Platform.UnitTests/TestHostOrchestratorManagerTests.cs:1

  • These assertions use string.Contains(...) without specifying comparison rules, which can make failures harder to reason about across cultures/casing and reduces clarity. Prefer using the Contains(string, StringComparison) overload (e.g., ordinal) and/or split this into two assertions so failures report which expected substring is missing.
    test/UnitTests/Microsoft.Testing.Platform.UnitTests/TestHostOrchestratorManagerTests.cs:1
  • These assertions use string.Contains(...) without specifying comparison rules, which can make failures harder to reason about across cultures/casing and reduces clarity. Prefer using the Contains(string, StringComparison) overload (e.g., ordinal) and/or split this into two assertions so failures report which expected substring is missing.

Comment thread src/Platform/Microsoft.Testing.Platform/Hosts/TestHostBuilder.cs Outdated
Comment thread src/Platform/Microsoft.Testing.Platform/Hosts/TestHostBuilder.cs Outdated
Comment thread src/Platform/Microsoft.Testing.Platform/Hosts/TestHostBuilder.cs Outdated
Comment thread src/Platform/Microsoft.Testing.Extensions.Retry/RetryExtensions.cs Outdated
Copilot AI review requested due to automatic review settings March 6, 2026 13:36
Comment thread src/Platform/Microsoft.Testing.Extensions.Retry/RetryExtensions.cs
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 33 out of 33 changed files in this pull request and generated 15 comments.

Comment thread src/Platform/Microsoft.Testing.Extensions.Retry/RetryExtensions.cs Outdated
Copilot AI review requested due to automatic review settings March 6, 2026 16:09
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 34 out of 34 changed files in this pull request and generated 1 comment.

@Evangelink Evangelink merged commit e1fc2d3 into main Mar 6, 2026
14 checks passed
@Evangelink Evangelink deleted the dev/amauryleve/orchestrator branch March 6, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Open up test host orchestrator for public consumption experimentally

3 participants