-
Notifications
You must be signed in to change notification settings - Fork 138
Allow flexible manifest specification, including production vs. development differences #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Contributor
Author
|
@stephenmichaelf are you able to look at this PR? If not, can you point me to someone who can? |
Contributor
|
@stephenmichaelf - Can you review this PR? |
jdrush89
approved these changes
Mar 26, 2021
Contributor
Author
|
@dwilsonactual can you merge this PR? I don't have write access. |
dwilsonactual
suggested changes
Mar 29, 2021
dwilsonactual
approved these changes
Apr 7, 2021
Contributor
|
I don't see how this closes #92. It doesn't seem to process the |
Contributor
Author
Contributor
|
Would love that functionality though :). There are ways the manifests interact. |
This was referenced Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for webpack-like configuration of the manifest file by giving the option to provide a manifest js file instead of a manifest json file.
From the updated documentation:
"Use the
--manifest-jsoption to supply a Node.JS CommonJS module and export a function. The function will be invoked with an environment property bag as a parameter, and must return the manifest JSON object. Environment variables for the property bag are specified with the--envcommand line parameter. These are space separated key-value pairs, e.g.--env mode=production rootpath="c:\program files" size=large."This can address scenarios described by the following issues. Fixes #161, Fixes #258.
An example manifest JS file might look like the following. It's inspired by David Hathaway's article on Streamlining Azure DevOps extension development but allows combining the development and release configs.