Skip to content

[Bug Fix] on-prem TFS missing collections #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShawnMcGough wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Bug Fix] on-prem TFS missing collections #453

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb60bc7
fix bug that allowed for missing collection for on-prem tfs
ShawnMcGough Mar 25, 2024
4c07420
Merge branch 'master' into master
ShawnMcGough Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/lib/connection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ export class TfsConnection {
throw new Error(
"Invalid service url - path is too long. A service URL should include the account/application URL and the collection, e.g. https://fabrikam.visualstudio.com/DefaultCollection or http://tfs-server:8080/tfs/DefaultCollection",
);
} else if (splitPath.length === 0) {
throw new Error("Expected URL path.");
} else if (splitPath.length === 0 || (splitPath[0] === "tfs" && splitPath.length === 1)) {
throw new Error("Expected URL path (collection name missing).");
}

if (splitPath[0].trim() !== "" || (splitPath[0] === "tfs" && splitPath[1].trim() !== "")) {
Expand Down