Skip to content

Conversation

@jessehouwing
Copy link
Contributor

@jessehouwing jessehouwing commented Aug 27, 2025

Improve clarity and consistency in the validation of execution handlers while updating the version.

This pull request refactors and improves the validation logic for task execution handlers in app/lib/jsonvalidate.ts, ensuring more robust and comprehensive validation across different execution types. It also bumps the package version in package.json to reflect these changes.

Validation logic improvements

  • Refactored execution handler validation by introducing the validateAllExecutionHandlers and validateExecutionTarget helper functions, allowing validation of execution, prejobexecution, and postjobexecution blocks uniformly.
  • Ensured that the validation function always returns an array of issues, even when the execution block is missing, preventing undefined return values for tasks without execution configuration.
  • Improved file existence checks for execution targets, including normalization of the target path and handling of variable substitutions.

Package version update

  • Updated the version in package.json from 0.22.0 to 0.22.1 to reflect these validation improvements.

Fixes: #511

@jessehouwing jessehouwing requested review from a team as code owners August 27, 2025 12:27
@jessehouwing
Copy link
Contributor Author

@tarunramsinghani

@tarunramsinghani
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tarunramsinghani tarunramsinghani merged commit f838fec into microsoft:master Sep 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extend target validation to also check the proper existence of the (prejob|postjob)execution target

2 participants